Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEL] 필요 없는 order 관련 로직 및 필드 삭제 #120

Merged
merged 19 commits into from
Mar 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
57a12b9
[DEL] 응원톡 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
206a637
[TEST] 응원톡 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
2ffed4e
[DOCS] 응원톡 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
a4772f6
[DEL] 사용되지 않는 CheerTalkQueryServiceTest 삭제 #119
Jin409 Mar 2, 2024
0ea07bb
[DEL] 게임 상세 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
b9b69d9
[TEST] 게임 상세 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
b6a2624
[DOCS] 게임 상세 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
6777111
[TEST] order 필드 삭제에 따른 gameTeamId 순으로 정렬되어 있는지 확인하는 테스트 추가 #119
Jin409 Mar 2, 2024
30bde1b
[DEL] 게임 전체 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
aeb0b39
[TEST] 게임 전체 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
8688485
[DOCS] 게임 전체 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
d5ef968
[DEL] 응원 횟수 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
79459c6
[TEST] 응원 횟수 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
c678a6d
[DOCS] 응원 횟수 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
5df8152
[DEL] 라인업 선수 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
3493bdb
[TEST] 라인업 선수 조회 시 팀 아이디의 오름차순으로 반환되는지 확인하는 테스트 추가 #119
Jin409 Mar 2, 2024
1b2667d
[TEST] 라인업 선수 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
148eb1b
[DOCS] 라인업 선수 조회 시 order 필드 삭제 #119
Jin409 Mar 2, 2024
569a6b9
[DEL] 사용되지 않는 GameTeamServiceUtils 삭제 #119
Jin409 Mar 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,8 @@ public List<CheerTalkResponse> getCheerTalksByGameId(final Long gameId, final Pa
gameId, pageRequest.cursor(), pageRequest.size()
);

List<Long> gameTeamIds = getOrderedGameTeamIds(cheerTalks);

List<CheerTalkResponse> responses = cheerTalks.stream()
.map(cheerTalk -> new CheerTalkResponse(
cheerTalk,
getOrderOfGameTeamId(cheerTalk.getGameTeamId(), gameTeamIds)
))
.map(CheerTalkResponse::new)
.collect(Collectors.toList());

Collections.reverse(responses);
Expand All @@ -44,8 +39,4 @@ private List<Long> getOrderedGameTeamIds(final List<CheerTalk> cheerTalks) {
.sorted()
.toList();
}

private int getOrderOfGameTeamId(final Long gameTeamId, final List<Long> gameTeamIds) {
return gameTeamIds.indexOf(gameTeamId) + 1;
}
}
Original file line number Diff line number Diff line change
@@ -1,34 +1,31 @@
package com.sports.server.query.application;

import static java.util.Comparator.comparingLong;

import com.sports.server.command.game.domain.Game;
import com.sports.server.command.game.domain.GameTeam;
import com.sports.server.query.dto.response.GameTeamCheerResponseDto;
import com.sports.server.common.application.EntityUtils;
import com.sports.server.query.dto.response.GameTeamCheerResponseDto;
import com.sports.server.query.repository.GameTeamQueryRepository;
import java.util.List;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;

import java.util.List;

import static java.util.Comparator.comparingLong;

@Service
@RequiredArgsConstructor
@Transactional(readOnly = true)
public class GameTeamQueryService {

private final GameTeamQueryRepository gameTeamQueryRepository;
private final GameTeamServiceUtils gameTeamServiceUtils;
private final EntityUtils entityUtils;

public List<GameTeamCheerResponseDto> getCheerCountOfGameTeams(final Long gameId) {
Game game = entityUtils.getEntity(gameId, Game.class);

return gameTeamQueryRepository.findAllByGame(game).stream()
.sorted(comparingLong(GameTeam::getId))
.map(gameTeam -> new GameTeamCheerResponseDto(gameTeam,
gameTeamServiceUtils.calculateOrderOfGameTeam(game, gameTeam)))
.map(gameTeam -> new GameTeamCheerResponseDto(gameTeam))
.toList();
}
}

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,12 @@

import static java.util.stream.Collectors.groupingBy;

import com.sports.server.command.game.domain.LineupPlayer;
import com.sports.server.query.repository.LineupPlayerQueryRepository;
import com.sports.server.command.game.domain.GameTeam;
import com.sports.server.command.game.domain.LineupPlayer;
import com.sports.server.query.dto.response.LineupPlayerResponse;
import com.sports.server.query.repository.LineupPlayerQueryRepository;
import java.util.ArrayList;
import java.util.Comparator;
import java.util.List;
import java.util.Map;
import lombok.RequiredArgsConstructor;
Expand All @@ -19,7 +20,6 @@
public class LineupPlayerQueryService {

private final LineupPlayerQueryRepository lineupPlayerQueryRepository;
private final GameTeamServiceUtils gameTeamServiceUtils;

public List<LineupPlayerResponse> getLineup(final Long gameId) {
Map<GameTeam, List<LineupPlayer>> groupByTeam = lineupPlayerQueryRepository.findPlayersByGameId(gameId)
Expand All @@ -29,8 +29,9 @@ public List<LineupPlayerResponse> getLineup(final Long gameId) {
List<GameTeam> gameTeams = groupByTeam.keySet().stream().toList();

return gameTeams.stream()
.map(gameTeam -> new LineupPlayerResponse(gameTeam, groupByTeam.getOrDefault(gameTeam, new ArrayList<>()),
gameTeamServiceUtils.calculateOrderOfGameTeam(gameTeams, gameTeam)))
.sorted(Comparator.comparingLong(GameTeam::getId))
.map(gameTeam -> new LineupPlayerResponse(gameTeam,
groupByTeam.getOrDefault(gameTeam, new ArrayList<>())))
.toList();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,15 @@ public record CheerTalkResponse(
String content,
Long gameTeamId,
LocalDateTime createdAt,
Boolean isBlocked,
int order
Boolean isBlocked
) {
public CheerTalkResponse(CheerTalk cheerTalk, final int order) {
public CheerTalkResponse(CheerTalk cheerTalk) {
this(
cheerTalk.getId(),
checkCheerTalkIsBlocked(cheerTalk),
cheerTalk.getGameTeamId(),
cheerTalk.getCreatedAt(),
cheerTalk.isBlocked(),
order
cheerTalk.isBlocked()
);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
import java.time.LocalDateTime;
import java.util.Comparator;
import java.util.List;
import java.util.stream.Collectors;
import java.util.stream.IntStream;

public record GameDetailResponse(
LocalDateTime startTime,
Expand All @@ -24,28 +22,25 @@ public GameDetailResponse(Game game, List<GameTeam> gameTeams) {
game.getGameQuarter(),
game.getName(),
game.getSport().getName(),
IntStream.range(0, gameTeams.size())
.boxed()
.sorted(Comparator.comparingLong(i -> gameTeams.get(i).getId()))
.map(i -> new TeamResponse(gameTeams.get(i), i + 1))
.collect(Collectors.toList())
gameTeams.stream()
.sorted(Comparator.comparingLong(GameTeam::getId))
.map(TeamResponse::new)
.toList()
);
}

public record TeamResponse(
Long gameTeamId,
String gameTeamName,
String logoImageUrl,
Integer score,
int order
Integer score
) {
public TeamResponse(GameTeam gameTeam, int order) {
public TeamResponse(GameTeam gameTeam) {
this(
gameTeam.getId(),
gameTeam.getLeagueTeam().getName(),
gameTeam.getLeagueTeam().getLogoImageUrl(),
gameTeam.getScore(),
order
gameTeam.getScore()
);
}
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,14 +1,11 @@
package com.sports.server.query.dto.response;

import com.sports.server.command.sport.domain.Sport;
import com.sports.server.command.game.domain.Game;
import com.sports.server.command.game.domain.GameTeam;

import com.sports.server.command.sport.domain.Sport;
import java.time.LocalDateTime;
import java.util.Comparator;
import java.util.List;
import java.util.stream.Collectors;
import java.util.stream.IntStream;

public record GameResponseDto(
Long id,
Expand All @@ -24,11 +21,10 @@ public GameResponseDto(final Game game, final List<GameTeam> gameTeams, final Sp
game.getStartTime(),
game.getGameQuarter(),
game.getName(),
IntStream.range(0, gameTeams.size())
.boxed()
.sorted(Comparator.comparingLong(i -> gameTeams.get(i).getId()))
.map(i -> new GameResponseDto.TeamResponse(gameTeams.get(i), i + 1))
.collect(Collectors.toList()),
gameTeams.stream()
.sorted(Comparator.comparingLong(GameTeam::getId))
.map(TeamResponse::new)
.toList(),
sport.getName()
);
}
Expand All @@ -37,15 +33,14 @@ public record TeamResponse(
Long gameTeamId,
String gameTeamName,
String logoImageUrl,
Integer score,
int order
Integer score
) {
public TeamResponse(GameTeam gameTeam, int order) {
public TeamResponse(GameTeam gameTeam) {
this(
gameTeam.getId(),
gameTeam.getLeagueTeam().getName(),
gameTeam.getLeagueTeam().getLogoImageUrl(),
gameTeam.getScore(), order
gameTeam.getScore()
);
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,10 @@

public record GameTeamCheerResponseDto(
Long gameTeamId,
int cheerCount,
int order
int cheerCount
) {
public GameTeamCheerResponseDto(final GameTeam gameTeam, final int order) {
this(gameTeam.getId(), gameTeam.getCheerCount(), order);
public GameTeamCheerResponseDto(final GameTeam gameTeam) {
this(gameTeam.getId(), gameTeam.getCheerCount());
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,17 @@
public record LineupPlayerResponse(
Long gameTeamId,
String teamName,
List<PlayerResponse> gameTeamPlayers,
int order
List<PlayerResponse> gameTeamPlayers

) {

public LineupPlayerResponse(GameTeam gameTeam, List<LineupPlayer> lineupPlayers, int order) {
public LineupPlayerResponse(GameTeam gameTeam, List<LineupPlayer> lineupPlayers) {
this(
gameTeam.getId(),
gameTeam.getLeagueTeam().getName(),
lineupPlayers.stream()
.map(PlayerResponse::new)
.toList(),
order
.toList()
);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@

import com.sports.server.command.cheertalk.domain.CheerTalk;
import com.sports.server.command.cheertalk.domain.CheerTalkCreateEvent;
import com.sports.server.query.dto.response.CheerTalkResponse;
import com.sports.server.common.application.EntityUtils;
import com.sports.server.query.application.GameTeamServiceUtils;
import com.sports.server.command.game.domain.Game;
import com.sports.server.command.game.domain.GameTeam;
import com.sports.server.common.application.EntityUtils;
import com.sports.server.query.dto.response.CheerTalkResponse;
import lombok.RequiredArgsConstructor;
import org.springframework.messaging.simp.SimpMessagingTemplate;
import org.springframework.scheduling.annotation.Async;
Expand All @@ -18,8 +17,6 @@
public class CheerTalkEventHandler {

private static final String DESTINATION = "/topic/games/";

private final GameTeamServiceUtils gameTeamServiceUtils;
private final EntityUtils entityUtils;
private final SimpMessagingTemplate messagingTemplate;

Expand All @@ -33,8 +30,7 @@ public void handle(CheerTalkCreateEvent event) {

messagingTemplate.convertAndSend(
DESTINATION + game.getId(),
new CheerTalkResponse(cheerTalk,
gameTeamServiceUtils.calculateOrderOfGameTeam(game, cheerTalk.getGameTeamId()))
new CheerTalkResponse(cheerTalk)
);

}
Expand Down
Loading
Loading