[FEAT] 게임 종료 스케줄링 추가 #292
Merged
[FEAT] 게임 종료 스케줄링 추가 #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldk980130
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
간단한 로직이라 리뷰할게 별로 없네 수고했어~
스케줄러를 더 자세히 테스트할 수 있는 방향이 있을지 고민됩니당
스케줄러를 테스트한다는게 스케줄링하는 로직을 테스트한다는건지 아니면 스프링의 스케줄러를 테스트한다는건지?
전자라면 사실 승희가 구현한 것처럼 스케줄러 내부는 아주 얇게 유지하고 로직은 다른 클래스에서 구현하고 따로 테스트하면 되는 것이고 (스케줄러 메서드에선 로깅, 에러 처리, 핵심 로직 호출만 하도록)
후자라면 사실 스프링이 잘 제공해주는 기능이니까 테스트할 필요는 굳이 없다고 생각해.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌍 이슈 번호
📝 구현 내용
🍀 확인해야 할 부분