From 1327419776c244867a101b3ff1dc0b9247ed0650 Mon Sep 17 00:00:00 2001 From: Baye Dieng Date: Thu, 11 Jan 2024 17:14:12 +0000 Subject: [PATCH 1/2] close ifdef --- candle-metal-kernels/src/cast.metal | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/candle-metal-kernels/src/cast.metal b/candle-metal-kernels/src/cast.metal index e08931cf74..ac40bc16aa 100644 --- a/candle-metal-kernels/src/cast.metal +++ b/candle-metal-kernels/src/cast.metal @@ -89,7 +89,6 @@ CAST(cast_i64_f32, cast_i64_f32_strided, int64_t, float) #if __METAL_VERSION__ >= 310 CAST(cast_bf16_u32, cast_bf16_u32_strided, bfloat, uint32_t) CAST(cast_bf16_f32, cast_bf16_f32_strided, bfloat, float) - CAST(cast_u8_bf16, cast_u8_bf16_strided, uint8_t, bfloat) CAST(cast_u32_bf16, cast_u32_bf16_strided, uint32_t, bfloat) CAST(cast_f32_bf16, cast_f32_bf16_strided, float, bfloat) @@ -98,3 +97,4 @@ CAST_THROUGH(cast_bf16_u8, cast_bf16_u8_strided, bfloat, uint8_t, float) CAST_THROUGH(cast_bf16_f16, cast_bf16_f16_strided, bfloat, half, float) CAST_THROUGH(cast_f16_bf16, cast_f16_bf16_strided, half, bfloat, float) #endif +#endif \ No newline at end of file From 85e568027731e58b72fb2798c525a5d8aff65eb8 Mon Sep 17 00:00:00 2001 From: Baye Dieng Date: Thu, 11 Jan 2024 21:02:03 +0000 Subject: [PATCH 2/2] remove metal version check --- candle-metal-kernels/src/cast.metal | 2 -- 1 file changed, 2 deletions(-) diff --git a/candle-metal-kernels/src/cast.metal b/candle-metal-kernels/src/cast.metal index ac40bc16aa..9aead139d0 100644 --- a/candle-metal-kernels/src/cast.metal +++ b/candle-metal-kernels/src/cast.metal @@ -86,7 +86,6 @@ CAST(cast_i64_f32, cast_i64_f32_strided, int64_t, float) #endif #if defined(__HAVE_BFLOAT__) -#if __METAL_VERSION__ >= 310 CAST(cast_bf16_u32, cast_bf16_u32_strided, bfloat, uint32_t) CAST(cast_bf16_f32, cast_bf16_f32_strided, bfloat, float) CAST(cast_u8_bf16, cast_u8_bf16_strided, uint8_t, bfloat) @@ -96,5 +95,4 @@ CAST(cast_f32_bf16, cast_f32_bf16_strided, float, bfloat) CAST_THROUGH(cast_bf16_u8, cast_bf16_u8_strided, bfloat, uint8_t, float) CAST_THROUGH(cast_bf16_f16, cast_bf16_f16_strided, bfloat, half, float) CAST_THROUGH(cast_f16_bf16, cast_f16_bf16_strided, half, bfloat, float) -#endif #endif \ No newline at end of file