Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant metal version check #1567

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

bayedieng
Copy link
Contributor

ifdef directive is not properly closed here which causes error.

@ivarflakstad
Copy link
Member

Ah, I see what happened here. Those two #ifs are redundant.
Could you instead remove #if __METAL_VERSION__ >= 310? 😊

Copy link
Contributor Author

@bayedieng bayedieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ivarflakstad ivarflakstad changed the title close ifdef Remove redundant metal version check Jan 11, 2024
@ivarflakstad ivarflakstad merged commit c1876b8 into huggingface:main Jan 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants