svelte-5-leftover-mobile-nav #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love the component testing!! Tried to do it in #1692 but i was struggling to make it work, so glad to see it here haha Once the conflicts are resolved I can run the tests to make sure it works :) |
nsarrazin
added
enhancement
|
I have a MongoMemoryServer error on my local machine, even on main. I haven't been able to get rid of it. Do you have the same problem? It's quite strange! 😄 |
isaiahr85
approved these changes
Feb 10, 2025
isaiahr85
approved these changes
Feb 10, 2025
vvnsrzn
force-pushed
the
svelte-5-leftover-mobile-nav
branch
2 times, most recently
from
7f2637e to
895abd7
Compare
|
I removed the testing part. I could have a look on #1692 to check how it goes. Hope this will work :) |
vvnsrzn
force-pushed
the
svelte-5-leftover-mobile-nav
branch
from
3f565a4 to
895abd7
Compare
nsarrazin
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @nsarrazin!
Thank you for your reply on #1668
I worked on the first component of your list.
I suggested a component testing strategy to be sure that my refactor is not going too far 😄
Feel free to discard it if it's not something you want/need.
Following #1691