-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hunyuan3D-2 Library #1241
Add Hunyuan3D-2 Library #1241
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Zeqiang-Lai - Thanks for the PR. Is this PR for: https://huggingface.co/tencent/Hunyuan3D-2/tree/main
In general our recommendation is to have individual repos for individual models, instead of having single monorepo. This also allows for getting visibility to the individual checkpoints as well and makes it easy for downstream apps to manage them as well.
Bonus: This way you also get individual granular download counts for different types of repos.
In addition to this, if we merge this change, for each folder we'll count all the safetsensors - that would inflate the download counts for each checkpoint by 5-6x and for the repo - 25-30x (given the other checkpoints in the same repo)
Thanks vaibhavs We are planning to release future model individually. But we need to keep current one for backward compatibility. The current repo contains 4 models, the paint and delight models are diffusers formatted, while the shape model is custom. It seems that when config.json in root is downloaded, the count increases. This means the count only count snapshot download of full model. We would like to measure the total download of these 4 models. It is possible to do that? What's the recommended way to correct it? |
prettyLabel: "Hunyuan3D-2", | ||
repoName: "Hunyuan3D-2", | ||
repoUrl: "https://github.com/Tencent/Hunyuan3D-2", | ||
countDownloads: `path_extension:"safetensors" OR path_extension:"ckpt"`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
countDownloads: `path_extension:"safetensors" OR path_extension:"ckpt"`, | |
countDownloads: `path:"model_index.json" OR path:"config.yaml"`, |
Chatted with @Wauplin and we think that this is a good compromise as only one or the other are used and this is still quite future proof even when you split to other repos as well! Let me know if this doesn't work for you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, this solution would be great! I just made an edition according to the suggesiton.
Thanks for the PR @Zeqiang-Lai and for iterating on feedback - please make sure that all future repos (even the splitted ones) have the same tag as in the PR. The download counts should be live in 3-4 days! Cheers! |
No description provided.