Add back call ID to TOOL_RESPONSE messages #1225
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
approved these changes
Apr 22, 2025
There was a problem hiding this comment.
Thanks for the catch and the fix.
I agree this is a breaking change, and I would suggest we revert it.
Maybe @aymeric-roucher can provide some context on why the "call id" was removed in his PR. I didn't see this change mentioned in the description, so it would be helpful to understand the rationale.
PR code introducing the breaking change:
05ccd4c#diff-dcc7ca96bae7047bbaf709e9252bfde503b58d77cba5ceefa5e93e05b3a4b33fL111-R125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add back "Call id:" section to
TOOL_RESEPONSEmessages which was removed in #1148.Fixes #1224.