Avoid running neuron integration tests twice #3054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
dacorvo
force-pushed
the
avoid_testing_neuron_twice
branch
from
7f94375 to
9b213b4
Compare
tengomucho
reviewed
Feb 25, 2025
| @@ -224,3 +229,7 @@ def neuron_model_config(request): | |||
| @pytest.fixture(scope="module") | |||
| def neuron_model_path(neuron_model_config): | |||
| yield neuron_model_config["neuron_model_path"] | |||
|
|
|||
|
|
|||
| if __name__ == "__main__": | |||
There was a problem hiding this comment.
why do you need a main here, aren't you going to run it as a test only?
There was a problem hiding this comment.
OK I got my answer, you run it on the workflow to export models.
| @@ -13,3 +13,4 @@ TGI remains consistent across backends, allowing you to switch between them seam | |||
| However, it requires a model-specific compilation step for each GPU architecture. | |||
| * **[TGI Llamacpp backend](./backends/llamacpp)**: This backend facilitates the deployment of large language models | |||
| (LLMs) by integrating [llama.cpp][llama.cpp], an advanced inference engine optimized for both CPU and GPU computation. | |||
| * **[TGI Neuron backend](./backends/neuron)**: This backend leverages the [AWS Neuron SDK](https://awsdocs-neuron.readthedocs-hosted.com/en/latest/) to allow the deployment of large language models (LLMs) on [AWS Trainium and Inferentia chips](https://aws.amazon.com/ai/machine-learning/trainium/). | |||
There was a problem hiding this comment.
do they run also on trainium?
tengomucho
approved these changes
Feb 25, 2025
Also rename fixture file fro clarity.
CARGO_REGISTRIES_CRATES_IO_PROTOCOL=sparse is not required anymore.
dacorvo
force-pushed
the
avoid_testing_neuron_twice
branch
from
92d2e6f to
b370902
Compare
Narsil
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This modifies the neuron
integration-testsfixture that compiles and exports models before running tests to be able to run it as a script and export all neuron test models at once.The script is now called during the
precompile_neuron_modelsCI step instead of running the full integration tests.This also updates the documentation to fix some obsolete links.