feat: add support for HF_HUB_USER_AGENT_ORIGIN to add user-agent Origin field in Hub requests. #3061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in field in Hub requests.
angt
reviewed
Feb 28, 2025
Dockerfile.neuron
Outdated
| @@ -18,7 +18,7 @@ RUN apt-get update -y \ | |||
| && rm -rf /var/lib/apt/lists/* \ | |||
| && apt-get clean | |||
|
|
|||
| RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- --default-toolchain 1.80.1 --profile minimal -y | |||
| RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- --default-toolchain 1.84.0 --profile minimal -y | |||
There was a problem hiding this comment.
You can use rust-toolchain.toml:
COPY rust-toolchain.toml rust-toolchain.toml
RUN curl -sSf https://sh.rustup.rs | sh -s -- -y --no-modify-path --default-toolchain none
There was a problem hiding this comment.
We can also not pipe anything into sh while we're at it, but there are unfortunately a lot of these occurrences.
There was a problem hiding this comment.
I'm not sure of what would be the best way to avoid the pipe. rustup-init checks the architecture to download the right installer which we need to do. We could copy rustup-init in the repo and add a check for rust-init signature for each architecture but needs to be updated for each update. Do you have other ideas in mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for HF_HUB_USER_AGENT_ORIGIN to add user-agent Origin field in Hub requests.
Useful to track collabs.