Skip to content

Commit a75abbe

Browse files
authored
Merge pull request #122 from humhub/fix/40-hard-delete-on-disable-module
Hard delete records on disable module
2 parents 9e1cb62 + 6c700df commit a75abbe

File tree

3 files changed

+10
-6
lines changed

3 files changed

+10
-6
lines changed

Module.php

+2-2
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public function getContentContainerTypes()
5252
public function disable()
5353
{
5454
foreach (Poll::find()->all() as $poll) {
55-
$poll->delete();
55+
$poll->hardDelete();
5656
}
5757

5858
parent::disable();
@@ -64,7 +64,7 @@ public function disable()
6464
public function disableContentContainer(ContentContainerActiveRecord $container)
6565
{
6666
foreach (Poll::find()->contentContainer($container)->all() as $poll) {
67-
$poll->delete();
67+
$poll->hardDelete();
6868
}
6969

7070
parent::disableContentContainer($container);

docs/CHANGELOG.md

+4
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
Changelog
22
=========
33

4+
1.3.0 (May 1, 2023)
5+
-------------------
6+
- Fix #122: Hard delete records on disable module
7+
48
1.2.2 (Unreleased)
59
-------------------------
610
- Fix #117: Fix responsive layout bug

module.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
"name": "Polls",
44
"description": "Easy to use poll system",
55
"keywords": ["poll", "voting", "decision making"],
6-
"version": "1.2.2",
6+
"version": "1.3.0",
77
"humhub": {
8-
"minVersion": "1.13"
8+
"minVersion": "1.14"
99
},
1010
"homepage": "https://github.com/humhub/polls",
1111
"authors": [
@@ -20,8 +20,8 @@
2020
}
2121
],
2222
"screenshots": [
23-
"assets/screen1.PNG",
24-
"assets/screen2.PNG",
23+
"assets/screen1.PNG",
24+
"assets/screen2.PNG",
2525
"assets/screen3.PNG",
2626
"assets/screen4.PNG"
2727
]

0 commit comments

Comments
 (0)