sonar missing scan details' lastExecutionTime update (#52)

* sonar scan missing detail last execution time update * version updated * version updated * getting the top item by timestamp
hygieia · Sep 1, 2020 · 8074e59 · 8074e59
1 parent b2d75b4
commit 8074e59
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/pom.xml b/pom.xml
@@ -4,7 +4,7 @@
     <artifactId>api-audit</artifactId>
     <packaging>jar</packaging>
     <name>${project.groupId}:${project.artifactId}</name>
-    <version>3.3.8-SNAPSHOT</version>
+    <version>3.3.9-SNAPSHOT</version>
     <description>Hygieia Audit Rest API Layer</description>
     <url>https://github.com/Hygieia/${repository.name}</url>
 

diff --git a/src/main/java/com/capitalone/dashboard/evaluator/CodeQualityEvaluator.java b/src/main/java/com/capitalone/dashboard/evaluator/CodeQualityEvaluator.java
@@ -208,11 +208,13 @@ private CodeQualityAuditResponse codeQualityDetailsForMissingStatus(CollectorIte
         detailsMissing.addAuditStatus(CodeQualityAuditStatus.CODE_QUALITY_DETAIL_MISSING);
         detailsMissing.setLastUpdated(codeQualityCollectorItem.getLastUpdated());
         detailsMissing.setAuditEntity(codeQualityCollectorItem.getOptions());
-        List<CodeQuality> codeQualities = codeQualityRepository.findByCollectorItemIdOrderByTimestampDesc(codeQualityCollectorItem.getId());
-        for(CodeQuality returnCodeQuality:codeQualities) {
-            detailsMissing.setUrl(returnCodeQuality.getUrl());
-            detailsMissing.setName(returnCodeQuality.getName());
-            detailsMissing.setLastExecutionTime(returnCodeQuality.getTimestamp());
+        Optional<CodeQuality> codeQualityOpt = Optional.ofNullable(
+                codeQualityRepository.findTop1ByCollectorItemIdOrderByTimestampDesc(codeQualityCollectorItem.getId()));
+        if (codeQualityOpt.isPresent()) {
+            CodeQuality codeQuality = codeQualityOpt.get();
+            detailsMissing.setUrl(codeQuality.getUrl());
+            detailsMissing.setName(codeQuality.getName());
+            detailsMissing.setLastExecutionTime(codeQuality.getTimestamp());
         }
         return detailsMissing;
     }