Merge pull request #174 from tatlax3636/update-test-passing

Fix skipped test logic
hygieia · Jul 27, 2022 · 9cf0164 · 9cf0164
2 parents 24e9d2a + c8e57c8
commit 9cf0164
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/pom.xml b/pom.xml
@@ -4,7 +4,7 @@
     <artifactId>api-audit</artifactId>
     <packaging>jar</packaging>
     <name>${project.groupId}:${project.artifactId}</name>
-    <version>3.7.24-SNAPSHOT</version>
+    <version>3.7.25-SNAPSHOT</version>
     <description>Hygieia Audit Rest API Layer</description>
     <url>https://github.com/Hygieia/${repository.name}</url>
 

diff --git a/src/main/java/com/capitalone/dashboard/evaluator/FeatureTestResultEvaluator.java b/src/main/java/com/capitalone/dashboard/evaluator/FeatureTestResultEvaluator.java
@@ -181,7 +181,12 @@ private double getTestCasePassPercent(List<TestCapability> testCapabilities) {
                     testCapability.getTestSuites().parallelStream().mapToDouble(TestSuite::getSkippedTestCaseCount).sum()
             ).sum();
 
-            return ((testCaseSuccessCount + testCaseSkipCount)/totalTestCaseCount) * 100;
+            if(totalTestCaseCount == 0 || testCaseSkipCount == totalTestCaseCount){
+                return 100.0;
+            }
+
+            return (testCaseSuccessCount/(totalTestCaseCount - testCaseSkipCount)) * 100;
+
         }catch(Exception e){
             LOGGER.error("Could not get 'testCasePassPercent', setting to 0.0%");
             return 0.0;