Add null check for authorType check (#42)

hygieia · Jun 23, 2020 · c2d6d4d · c2d6d4d
1 parent 58cbfd1
commit c2d6d4d
Showing 1 changed file with 1 addition and 0 deletions.
diff --git a/src/main/java/com/capitalone/dashboard/evaluator/CodeReviewEvaluator.java b/src/main/java/com/capitalone/dashboard/evaluator/CodeReviewEvaluator.java
@@ -224,6 +224,7 @@ private CodeReviewAuditResponseV2 getPeerReviewResponses(CollectorItem repoItem,
     private void checkCommitByLDAPUnauthUser(CodeReviewAuditResponseV2 reviewAuditResponseV2, Commit commit) {
         if (StringUtils.isEmpty(commit.getScmAuthorLDAPDN()) &&
                 !CommonCodeReview.matchIncrementVersionTag(commit.getScmCommitLog(), settings) &&
+                commit.getScmAuthorType() != null &&
                 !commit.getScmAuthorType().equals(AuthorType.Bot)) {
             reviewAuditResponseV2.addAuditStatus(CodeReviewAuditStatus.SCM_AUTHOR_LOGIN_INVALID);
             // add commit made by unauth user to commitsByLDAPUnauthUsers list