feat: add commit time metrics #5380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x009922
force-pushed
the
commit-time-metrics
branch
from
fdee4a9 to
efdce1a
Compare
0x009922
commented
Mar 24, 2025
0x009922
force-pushed
the
commit-time-metrics
branch
from
efdce1a to
04841e6
Compare
0x009922
force-pushed
the
commit-time-metrics
branch
from
04841e6 to
79dc888
Compare
0x009922
requested review from
s8sato,
mversic,
outoftardis,
DCNick3 and
dima74
as code owners
aoyako
previously approved these changes
Apr 16, 2025
0x009922
force-pushed
the
commit-time-metrics
branch
from
e48f840 to
c943bda
Compare
|
Docker CI fails 😞 Opened #5398 |
aoyako
previously approved these changes
Apr 18, 2025
dima74
approved these changes
Apr 18, 2025
0x009922
force-pushed
the
commit-time-metrics
branch
from
48789c2 to
4236151
Compare
|
I noticed that tests sometimes fail because of the block stream disconnect. Some peers fail to send a message into the WebSocket within the timeout (10s) and close the stream. The test network then doesn't reconnect, and tests fail due to never reaching expected block height (which is detected by the block stream). I don't know why the iroha/crates/iroha_torii/src/stream.rs Line 22 in 5f8fd11 A solution could be to introduce a reconnection mechanism in the test network. Or increasing the timeout in Iroha. |
s8sato
reviewed
Apr 28, 2025
dima74
previously approved these changes
Apr 29, 2025
0x009922
force-pushed
the
commit-time-metrics
branch
from
7e23dab to
26fcb36
Compare
0x009922
force-pushed
the
commit-time-metrics
branch
from
adf642f to
9e62d5f
Compare
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
0x009922
force-pushed
the
commit-time-metrics
branch
from
9e62d5f to
cc04cf2
Compare
Signed-off-by: 0x009922 <43530070+0x009922@users.noreply.github.com>
dima74
approved these changes
May 2, 2025
aoyako
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
last_commit_time_msgauge andcommit_time_mshistogram (to observe trends)Statuswithcommit_time_ms(same as Prometheus'last_commit_time_ms)iroha_coreto clarify the data flow, introduced an actor. Also, finally made the feature-gate#[cfg(feature = "telemetry")]complete.Additionally:
tx_amountshistogram. It used default buckets1 which aren't suitable for amounts. I changed it to be in the rangesiroha_test_networkas mentioned in Improve test frameworkNetworkPeer::startfunction #5382 + addedtracinglogging for better tracking of time and scopes.Closes #5366
Closes #5388
Closes #5382
Closes #5404
API Changes
Status(fromGET /status) contains a new field:commit_time_ms(compactu64)TODO
Footnotes
DEFAULT_BUCKETS: "The default buckets are tailored to broadly measure the response time (in seconds) of a network service. Most likely, however, you will be required to define buckets customized to your use case" ↩