-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minor TypeScript issues and add ESLint TypeScript support #418
Conversation
Add "../../types/" as type package to **/test/typescript/tsconfig.json Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for these changes! Just two things to note:
- There seem to be some indentation issues in
tsconfig.json
files. I think caused by mixed spaces and tabs for indentation. This should be fixed. - Ideally the
tsconfig.json
files would make use of the standard base configuration for Node 18 (see here). This might cause issues with the requiredtypescript
version, which might in turn cause issues with the requiredeslint
version. This could happen outside of this PR.
Signed-off-by: Jerrylum <serverofjerry@gmail.com>
Thank you for your review. Firstly, I fixed all tsconfig.json files with 2-spaces indentation. Please check again. Secondly, the content of all new tsconfig.json was copied from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's probably better to consider using @tsconfig/node18
separately from this pull request so the current change looks good to me.
Thank you for the contribution!
Closes #415 #416 #417