Fix node-to-client support #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Gellis <simongellis@gmail.com>
Signed-off-by: Simon Gellis <simongellis@gmail.com>
Quantumplation
approved these changes
Feb 19, 2025
| pallas-primitives = "0.32" | ||
| pallas-network = "0.32" | ||
| pallas-traverse = "0.32" | ||
| pallas-addresses = { git = "https://github.com/SupernaviX/pallas.git", rev = "2e9b8b0" } |
There was a problem hiding this comment.
Note: just waiting on this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Fully support running the connector against a local cardano node (using Cardano's node-to-client protocol) without a blockfrost key. The connector already supported using node-to-client protocol for chainsync and tx submission, but needed to fall back to blockfrost for some essential operations.
connector.blockchain.socketis defined in config, the connector will use n2c over the socket at that path.connector.blockchain.blockfrostKeyis defined, the connector will run against blockfrost.Important Changes Introduced
request_block. The node-to-client protocol doesn't support fetching individual blocks, only staying in sync with an entire chain.blockchainmodule. Now blockfrost is one blockchain provider, and the rest of the connector is decoupled from it.