Extract IPC code to separate method #9223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it possible to use the same IPC code for more projects in the future
|
yeah, but why? For now we don't |
|
I'm not sure what you mean. I'm currently working on adding IPC support to Hyprsunset, this PR prepares for when that's actually ready to merge. |
|
ah, ok |
vaxerski
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
This makes it possible to use the same IPC code for more projects in the future.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
This doesn't do much yet, but I'm planning to add IPC support to Hyprsunset, and this will be useful for that (as well as for any other Hypr* projects that need IPC in the future)
Is it ready for merging, or does it need work?
Yes, it should be ready to merge.