feat(anr): add xwayland support

[nnyyxxxx]

adds xwayland support to anr

fixes #7297

[nnyyxxxx]

i haven't tested the wayland part (might wanna look into that) regardless xwayland support is finished

[Kommynct]

pretty sure this fixes #7297

[nnyyxxxx]

sure, anr was already implemented for wayland all this does is add support for xwayland

if i am being honest that issue should have been closed with fb8eaba but i digress

their are probably more issues related to that one, i cba to find them right now though.

[vaxerski]

I don't like this, fails the vibe check, so much code dup

[nnyyxxxx]

I don't like this, fails the vibe check, so much code dup

wdym?

[nnyyxxxx]

this pr avoids that lol, shared code is extracted to helper funcs etc

[nnyyxxxx]

could you clarify?

[nnyyxxxx]

ill draft then lol and extract more logic since you dont want to give context

[nnyyxxxx]

just sayin it was pretty bad before as well so

[nnyyxxxx]

better?

[nnyyxxxx]

this is going to be aids to review

[nnyyxxxx]

tbh the duplication is kinda unavoidable...

[nnyyxxxx]

going to undraft, feel free to revert e195d94 if you dont like it

[nnyyxxxx]

their is really no other way to do this if im being real... and tbh even if e195d94 reduces code duplication ( very minor ) i still prefer it without those changes....

[nnyyxxxx]

https://www.youtube.com/watch?v=1xcvWmN0Pe4

[vaxerski]

tbh I am not very convinced this is even something I am interested in. XWayland is slow, hungry, and I'd avoid sending anything more than we need over it.

There are already some event issues around xwl that cause elevated cpu usage on my laptop (thats why I have to have xwl disabled on it)

[nnyyxxxx]

tbh I am not very convinced this is even something I am interested in. XWayland is slow, hungry, and I'd avoid sending anything more than we need over it.

There are already some event issues around xwl that cause elevated cpu usage on my laptop (thats why I have to have xwl disabled on it)

but the implementation isnt even bad lol, if you dont want to support xwayland on a lot of things then why have it in the first place. xd.

[nnyyxxxx]

also want to resume this on the discord server? if you unban me of course :)

[nnyyxxxx]

most users will want this anyways, if we stripped out a lot of the xwayland stuff and made it barebones, then the users would just want those features back. theres nothing really stopping this anyways

[vaxerski]

I'll see what I can do tomorrow.

[nnyyxxxx]

I'll see what I can do tomorrow.

any updates on this

[vaxerski]

yes, I had other stuff to do and didnt, I have this open for wehn I have amoment

[nnyyxxxx]

yes, I had other stuff to do and didn't, I have this open for when I have a moment

ok

[vaxerski]

you've messed up the code royally, I'll just rewrite it probably

[nnyyxxxx]

whats wrong with it 💀

[nnyyxxxx]

tested on both wayland and xwayland works pefectly,

disregard this:

i haven't tested the wayland part (might wanna look into that) regardless xwayland support is finished

[nnyyxxxx]

their is no better way to do this regarding code dupe if thats what you mean

feel free to test out these changes yourself if you dont believe me :(

[nnyyxxxx]

also want to resume this on the discord server? if you unban me of course :)

e

[vaxerski]

you shat templates all over

also, it doesn't work on my end

[nnyyxxxx]

you shat templates all over

also, it doesn't work on my end

skill issue, works perfectly fine for me

[nnyyxxxx]

u dont know xwayland well enough, you probs tried triggering it wrong

[nnyyxxxx]

you shat templates all over

templates are great

[nnyyxxxx]

also want to resume this on the discord server? if you unban me of course :)

unban me pls @vaxerski

[nnyyxxxx]

closing in favor #9456