Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant needsFrame & allow frame schedule skipping on mouse move #21

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

UjinT34
Copy link
Contributor

@UjinT34 UjinT34 commented Jul 20, 2024

  • Removes needsFrame = true before scheduleFrame since it is set inside. Useful for logging needsFrame changes.
  • Adds optional skipShedule argument to moveCursor to allow cursor:no_break_fs_vrr with hw cursors

skipShedule requires HL updates to be useful. Just passing true to moveCursor is not enough to fix VRR. Probably needs something like hyprwm/Hyprland#6877 for hw cursors.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fail to see a point. Why not just... not move the cursor?

@UjinT34
Copy link
Contributor Author

UjinT34 commented Jul 20, 2024

It is not guaranteed that the cursor position will be updated to the correct value when something finally decides that the frame should be rendered. Something needs to update the cursor position between frames without triggering extra frames. I think it's easier to skip frame schedule than to call an extra moveCursor under complex conditions.
Not moving the cursor will definitely solve the VRR issues but that's not what humans want. They can't keep their hands off the mouse and tend to get disappointed when their cursor is stuck in place %)

@vaxerski
Copy link
Member

ok

@vaxerski vaxerski merged commit 7a84686 into hyprwm:main Jul 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants