Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow symlinks for AQ_DRM_DEVICES #34

Merged
merged 21 commits into from
Jul 26, 2024
Merged

Conversation

sjcobb2022
Copy link
Contributor

@sjcobb2022 sjcobb2022 commented Jul 25, 2024

Addresses #33

Iterates over explicitly declared GPUs and canonicalizes paths. This has the additional include of <filesystem>
and <system_error>.

Currently does not check if the device is a valid drm KMS device. This could be added in the future.

Sorry for the messy git tree. Probably better to squash.

Note: This works for me, but additional testing would be greatly appreciated.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool. We verify in a different place (if a device is not KMS, we wont accept it anyways) but an error would be nice yes

@sjcobb2022
Copy link
Contributor Author

sjcobb2022 commented Jul 26, 2024

Alright, should I check for drmIsKms in this pull or a new one?

@vaxerski
Copy link
Member

new one, I'll merge this. Sorry for my lack of respinsiveness I am in the middle of nowhere on a "kinda break"

@vaxerski vaxerski merged commit f95d150 into hyprwm:main Jul 26, 2024
1 check passed
@sjcobb2022
Copy link
Contributor Author

new one, I'll merge this. Sorry for my lack of respinsiveness I am in the middle of nowhere on a "kinda break"

Aw good for you. Have a nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants