core: fix sleep delay and simplify process spawning #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaideiaDilemma
force-pushed
the
fix-inhibit-and-process-stuff
branch
from
d50ea65 to
29bb352
Compare
PaideiaDilemma
force-pushed
the
fix-inhibit-and-process-stuff
branch
from
219d993 to
2ac0133
Compare
|
can confirm this completely fixes the issue for me. System now sleeps immediately after I see hyprlock show up :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So releasing the sleep inhibitor did not work properly so far, cause of forked fds.
That lead to suspend taking max delay seconds, which defaults to 5. (I used a
sleep 4 && hyprlockto test that the system does not go sleep, so I did not notice.)As can be seen in my comments, for some reason we still need to explicitly close the fd in the child process despite setting O_CLOEXEC, which is weird.I removed the second fork cause we don't need it in hypridle, which also allowed to set SA_NOCLDWAIT and stuff which is nice to have for a daemon process.