Skip to content

Commit

Permalink
Improve CHANGELOG for <EditableTextLabel> changes
Browse files Browse the repository at this point in the history
  • Loading branch information
zhusee2 committed Aug 15, 2017
1 parent 8f03f40 commit b801897
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,14 @@ N/A

## [1.1.0]
### Changed
- Fix `<EditableTextLabel>` not supporting custom icon.
- `<EditableTextLabel>` now does not fire `onEditRequest` callback, leaving users to decide when to control its editing state.
- `<EditableTextLabel>` now simulates double-touch and then triggers `onDblClick` callback.
- When the `inEdit` prop isn't set on `<EditableTextLabel>`, it becomes an uncontrolled component and will auto enter edit mode on double clicks.
- API changes to `<EditableTextLabel>`:
* `inEdit` prop now defaults to `undefined`, which means the component is **uncontrolled**.
* When `inEdit` is set either `true` or `false`, the component is **controlled**
* ~`onEditRequest`~ prop is removed in favor of new `onDblClick` callback. Users can decide when to update the edit state.
- Behavior changes to `<EditableTextLabel>`:
* Custom element passed via `icon` now renders correctly under edit mode
* Double touch on mobile devices also triggers `onDblClick` callback.
* If component is **uncontrolled**, it auto enters edit mode on double clicks/touches and leaves on edit ends.

## [1.0.0]
### Added
Expand Down

0 comments on commit b801897

Please sign in to comment.