Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project/upgrade react v18 #421

Merged
merged 41 commits into from
Jan 26, 2024
Merged

Project/upgrade react v18 #421

merged 41 commits into from
Jan 26, 2024

Conversation

kyoyadmoon
Copy link
Member

@kyoyadmoon kyoyadmoon commented Dec 20, 2023

Purpose

升級 React 18 的 project branch,PR 應該都 review 過了

upgrade webpack to v5
upgrade webpack loaders
replace node-sass to sass
…pack5

Docs/upgrade-storybook-v6-with-webpack5
…part1

Refactor/remove-unsafe-lifecycles-part1
…part2

refactor: Refactor SelectList component to use React hooks
…part3

refactor: Refactor SelectRow component to use React hooks
…part4

refactor: Refactor componentDidUpdate in ImageEditor.js
…ble-touch

refactor: Refactor EditableTextLabel component to use useRef
Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (0f13c76) 88.47% compared to head (7076e66) 97.99%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #421      +/-   ##
===========================================
+ Coverage    88.47%   97.99%   +9.51%     
===========================================
  Files          152       69      -83     
  Lines         1544     1443     -101     
  Branches       283      279       -4     
===========================================
+ Hits          1366     1414      +48     
+ Misses         178       29     -149     
Files Coverage Δ
packages/core/src/StatusIcon.js 100.00% <100.00%> (ø)
packages/imageeditor/src/ImageEditor.js 98.33% <100.00%> (+0.15%) ⬆️
packages/form/src/SelectList.js 98.75% <98.64%> (-0.09%) ⬇️
packages/form/src/SelectRow.js 98.87% <98.68%> (+0.15%) ⬆️
packages/form/src/SwitchRow.js 94.11% <94.11%> (-5.89%) ⬇️
packages/core/src/EditableBasicRow.js 94.59% <93.54%> (-5.41%) ⬇️
packages/core/src/EditableTextLabel.js 96.66% <96.61%> (-3.34%) ⬇️

... and 99 files with indirect coverage changes

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@kyoyadmoon kyoyadmoon marked this pull request as ready for review January 26, 2024 03:01
@kyoyadmoon kyoyadmoon requested review from tz5514 and chenesan January 26, 2024 03:42
@kyoyadmoon kyoyadmoon merged commit 6c2bb2a into develop Jan 26, 2024
9 of 10 checks passed
@kyoyadmoon kyoyadmoon deleted the project/upgrade-react-v18 branch January 26, 2024 04:25
@zhusee2 zhusee2 added this to the v7 milestone Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants