Make the TrueJet processor use the PIDHandler to set the ParticleIDs #132

tmadlener · 2024-05-07T15:23:00Z

BEGINRELEASENOTES

Make the TrueJet processor use the PIDHandler to set the ParticleIDs for the different objects it creates. This sets the necessary metadata that is required, e.g. for the conversion to EDM4hep.

ENDRELEASENOTES

@Zehvogel can you check whether this fixes things on your end? At least from a technical level, the algorithm names might still need some tuning, but I would also be interested to see which ones are actually hit / converted.

Analysis/TrueJet/src/TrueJet.cc

Zehvogel · 2024-05-08T06:27:43Z

Yes I will test it. It would probably also be good if someone who uses the MarlinUtil TrueJet parser can test if that still works with this change. Maybe someone at DESY? :)

tmadlener · 2024-05-08T08:19:36Z

Thanks. In principle nothing should have changed other than that we are now writing some additional metadata as well. I will check if that is actually true.

Zehvogel · 2024-05-08T15:07:15Z

This fixes running TrueJet for me. I still need to adapt my RDataframe code to work on the new direction though.
However I compared the podio-dump output after this change and before reversal of the PID collection and it looks like everything is correct. Depending on what kind of events one uses a lot of the PIDs will stay empty.

As far as I can tell *_PID_TrueJet_*_jet_n is filled for the n-th jet belonging to the initial/final colour neutral. I have no idea how this will ever reach values much greater than two... maybe @MikaelBerggren can comment if we really need 25? Also the 0'th one is never filled? The files become really crowded at the moment with all of them in there...

I attached the above-mentioned podio-dump outputs if anyone wants to take a look :)

truejet_oldpid.txt
truejet_newpid.txt

tmadlener · 2024-05-08T15:10:55Z

Analysis/TrueJet/src/TrueJet.cc

+      auto fafpf_mainPidId = fafpfPidHandler.addAlgorithm("TrueJet_fafpf", {});
+      std::array<int, 25> fafpf_pidIds{};
+      for (size_t i = 0; i < fafpf_pidIds.size(); ++i) {
+          fafpf_pidIds[i] = fafpfPidHandler.addAlgorithm("TrueJet_fafpf_jet_" + std::to_string(i), {});


Suggested change

fafpf_pidIds[i] = fafpfPidHandler.addAlgorithm("TrueJet_fafpf_jet_" + std::to_string(i), {});

fafpf_pidIds[i] = fafpfPidHandler.addAlgorithm("TrueJet_fafpf_jet_" + std::to_string(i + 1), {});

Also the 0'th one is never filled? The files become really crowded at the moment with all of them in there...

doesn't this do the opposite? I.e. it just renames 0 to 1 but it will still never be filled?

It doesn't fix that, but I just remembered I wanted to do this, because previously the one that goes currently into the "main" PID went into 0.

tmadlener · 2024-05-08T15:11:24Z

Analysis/TrueJet/src/TrueJet.cc

+      auto fafpi_mainPidId = fafpiPidHandler.addAlgorithm("TrueJet_fafpi", {});
+      std::array<int, 25> fafpi_pidIds{};
+      for (size_t i = 0; i < fafpi_pidIds.size(); ++i) {
+          fafpi_pidIds[i] = fafpiPidHandler.addAlgorithm("TrueJet_fafpi_jet_" + std::to_string(i), {});


Suggested change

fafpi_pidIds[i] = fafpiPidHandler.addAlgorithm("TrueJet_fafpi_jet_" + std::to_string(i), {});

fafpi_pidIds[i] = fafpiPidHandler.addAlgorithm("TrueJet_fafpi_jet_" + std::to_string(i + 1), {});

tmadlener · 2024-05-08T16:11:13Z

Also the 0'th one is never filled? The files become really crowded at the moment with all of them in there...

I am not sure if this can even be checked easily, but were these filled before?

Zehvogel · 2024-05-13T13:03:40Z

Also the 0'th one is never filled? The files become really crowded at the moment with all of them in there...

I am not sure if this can even be checked easily, but were these filled before?

I think that the 0'th one was not filled was expected if you start the counting of the jets per ICN by 1. There is no ICN/FCN with no truejet belonging to it. So that one seems to be simply left over.

For the values > 2 I am not so sure. I think 3 and 4 are used relatively often (as soon as you have gluon-splitting etc.).

Leaving my area of expertise even more I would guess that a final colour neutral would by definition always result in two (true)jets while an initial colour neutral can have $2n$ (true)jets where $n$ is the number of final colour neutrals it hadronises into.

So maybe we can at least reduce the amount of fafpf PIDs to two (three including the main one)?

tmadlener · 2024-06-19T14:31:40Z

After merging #134, we have almost halfed the number of ParticleID objects that will be visible once this has been converted to EDM4hep. For the initial state side there is no generally applicable way to do this. The number 25 has been chosen to work at ILD up to 1 TeV. At lower energies this might be smaller. I think the easiest way of dealing with this might be to simply drop the "superfluous" collections via the KeepDropSwitch and configuration (untested) along the lines of

# ...
"drop *_PID_TrueJet_fafpi_jet1?",
"drop *_PID_TrueJet_fafpi_jet2?",
# and then maybe some single digits as well if you still want to get rid of more
# or alternatively drop all of them and keep only the ones you want, might be the same number of lines

Zehvogel · 2024-06-20T07:14:57Z

Analysis/TrueJet/src/TrueJet.cc

@@ -837,6 +848,12 @@ void TrueJet::processEvent( LCEvent * event ) {
        // pre-PS part

      LCCollectionVec* fafpi_vec = new LCCollectionVec(LCIO::RECONSTRUCTEDPARTICLE ) ;
+      auto fafpiPidHandler = UTIL::PIDHandler(fafpi_vec);
+      auto fafpi_mainPidId = fafpiPidHandler.addAlgorithm("TrueJet_fafpi", {});
+      std::array<int, 25> fafpi_pidIds{};


I know the 25 is just the result of correctly making the 0'th pid the mainPid, but I wonder if the 26 before was correct? I would have thought that we would expect an even number here (after removal of the mainPid).

Zehvogel · 2024-06-20T07:55:33Z

Analysis/TrueJet/src/TrueJet.cc

+      auto fafpi_mainPidId = fafpiPidHandler.addAlgorithm("TrueJet_fafpi", {});
+      std::array<int, 25> fafpi_pidIds{};
+      for (size_t i = 0; i < fafpi_pidIds.size(); ++i) {
+          fafpi_pidIds[i] = fafpiPidHandler.addAlgorithm("TrueJet_fafpi_jet_" + std::to_string(i), {});


can we format this to left-pad with 0 to have nicer sorting in podio-dump etc.?

So basically, TrueJet_fafpi_jet_01 for example?

done. Should work until someone wants more than 99 of these ;)

Zehvogel · 2024-06-20T08:04:41Z

While you are in there anyway, do you mind setting

MarlinReco/Analysis/TrueJet/src/TrueJet.cc

Line 157 in 8c3f3b6

streamlog_out(WARNING) << " processing event: " << evt->getEventNumber()

to something like MESSAGE?

tmadlener commented May 7, 2024

View reviewed changes

Analysis/TrueJet/src/TrueJet.cc Outdated Show resolved Hide resolved

Analysis/TrueJet/src/TrueJet.cc Outdated Show resolved Hide resolved

Analysis/TrueJet/src/TrueJet.cc Outdated Show resolved Hide resolved

Analysis/TrueJet/src/TrueJet.cc Outdated Show resolved Hide resolved

tmadlener commented May 8, 2024

View reviewed changes

tmadlener mentioned this pull request Jun 19, 2024

TrueJet: Reduce the size of the ParticleID vector for final fermion anti fermion pair. Update doc and examples. #134

Merged

tmadlener added 2 commits June 19, 2024 16:04

Move headers into .cc file

1378a37

Use PIDHandler to set ParticleIDs

dc83d18

tmadlener force-pushed the truejet-pidhandler branch from feaee55 to dc83d18 Compare June 19, 2024 14:06

Fix a few minor issues

8c3f3b6

Zehvogel reviewed Jun 20, 2024

View reviewed changes

tmadlener added 2 commits June 20, 2024 14:10

Demote log message level to something more appropriate

ff1d00e

Make numbering zero padded

0139d70

tmadlener merged commit 34c6e80 into iLCSoft:master Jun 24, 2024
8 checks passed

tmadlener deleted the truejet-pidhandler branch June 24, 2024 08:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make the TrueJet processor use the PIDHandler to set the ParticleIDs #132

Make the TrueJet processor use the PIDHandler to set the ParticleIDs #132

tmadlener commented May 7, 2024

Zehvogel commented May 8, 2024

tmadlener commented May 8, 2024

Zehvogel commented May 8, 2024

tmadlener May 8, 2024

Zehvogel May 8, 2024

tmadlener May 8, 2024

tmadlener May 8, 2024

tmadlener commented May 8, 2024

Zehvogel commented May 13, 2024

tmadlener commented Jun 19, 2024

Zehvogel Jun 20, 2024

Zehvogel Jun 20, 2024

tmadlener Jun 20, 2024

Zehvogel Jun 20, 2024

tmadlener Jun 20, 2024

Zehvogel commented Jun 20, 2024

	fafpf_pidIds[i] = fafpfPidHandler.addAlgorithm("TrueJet_fafpf_jet_" + std::to_string(i), {});
	fafpf_pidIds[i] = fafpfPidHandler.addAlgorithm("TrueJet_fafpf_jet_" + std::to_string(i + 1), {});

	fafpi_pidIds[i] = fafpiPidHandler.addAlgorithm("TrueJet_fafpi_jet_" + std::to_string(i), {});
	fafpi_pidIds[i] = fafpiPidHandler.addAlgorithm("TrueJet_fafpi_jet_" + std::to_string(i + 1), {});

Make the TrueJet processor use the PIDHandler to set the ParticleIDs #132

Make the TrueJet processor use the PIDHandler to set the ParticleIDs #132

Conversation

tmadlener commented May 7, 2024

Zehvogel commented May 8, 2024

tmadlener commented May 8, 2024

Zehvogel commented May 8, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tmadlener commented May 8, 2024

Zehvogel commented May 13, 2024

tmadlener commented Jun 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zehvogel commented Jun 20, 2024