Disable service build optimization

Some users have reported the service as crashing.

While I have never been able to replicate this on any system I'm experimenting with disabling UPX optimization in case that is triggering an issue.

The trade off is build sizes will be slightly larger now.

Author: iaincollins

package.json

@@ -1,6 +1,6 @@
 {
   "name": "icarus",
-  "version": "0.21.1",
+  "version": "0.22.0",
   "description": "ICARUS Terminal for Elite Dangerous",
   "scripts": {
     "build": "npm run build:client && npm run build:app && npm run build:service && npm run build:package",

resources/images/download-button.svg

@@ -50,17 +50,17 @@ async function build () {
     fs.copyFileSync(APP_UNOPTIMIZED_BUILD, APP_OPTIMIZED_BUILD)
   } else {
     if (COMPRESS_FINAL_BUILD) {
-      console.log('Optimizing...')
+      console.log('Optimizing app build...')
       const optimisationStats = await UPX(APP_UNOPTIMIZED_BUILD)
         .output(APP_OPTIMIZED_BUILD)
         .start()
         .catch(err => {
           console.log('Error compressing build', err)
           process.exit(1)
         })
-      console.log('Optimization', optimisationStats)
+      console.log('Optimized app build', optimisationStats)
     } else {
-      console.log('Compression disabled (skipping compression)')
+      console.log('Compression disabled (skipping service build optimization)')
       fs.copyFileSync(APP_UNOPTIMIZED_BUILD, APP_OPTIMIZED_BUILD)
     }
   }

scripts/build-app.js

@@ -21,6 +21,7 @@ const {
 const DEVELOPMENT_BUILD = commandLineArgs.debug || DEVELOPMENT_BUILD_DEFAULT
 const DEBUG_CONSOLE = commandLineArgs.debug || DEBUG_CONSOLE_DEFAULT
 const ENTRY_POINT = path.join(__dirname, '..', 'src', 'service', 'main.js')
+const COMPRESS_FINAL_BUILD = false
 
 ;(async () => {
   clean()
@@ -63,11 +64,16 @@ async function build () {
     console.log('Development build (skipping compression)')
     fs.copyFileSync(SERVICE_UNOPTIMIZED_BUILD, SERVICE_FINAL_BUILD)
   } else {
-    console.log('Optimizing...')
-    const optimisationStats = await UPX(SERVICE_UNOPTIMIZED_BUILD)
-      .output(SERVICE_OPTIMIZED_BUILD)
-      .start()
-    console.log('Optimization', optimisationStats)
-    fs.copyFileSync(SERVICE_OPTIMIZED_BUILD, SERVICE_FINAL_BUILD)
+    if (COMPRESS_FINAL_BUILD) {
+      console.log('Optimizing service build...')
+      const optimisationStats = await UPX(SERVICE_UNOPTIMIZED_BUILD)
+        .output(SERVICE_OPTIMIZED_BUILD)
+        .start()
+      fs.copyFileSync(SERVICE_OPTIMIZED_BUILD, SERVICE_FINAL_BUILD)
+      console.log('Optimized service build', optimisationStats)
+    } else {
+      console.log('Compression disabled (skipping service build optimization)')
+      fs.copyFileSync(SERVICE_UNOPTIMIZED_BUILD, SERVICE_FINAL_BUILD)
+    }
   }
 }