Workaroud TWS API bug for bad FOP contract matches

When IBKR started offering "Event Contracts" for some reason the
contract matcher started returning Event Contracts _and_ FOP contracts
just for FOP requests, which is clearly wrong.

Now we do an extra level of checking to _only_ return the input security
type requested to prevent cross-instrument contract retrieval.

e.g. if you're requesting an NQ call contract, you don't want IBKR to
suggest "did you mean Event Contract for NQ closing over 21,000
instead?"

Now we just ignore any returned contracts not matching the input
security type (if an input security type was provided).

Author: mattsta

ib_async/ib.py

@@ -2133,10 +2133,36 @@ async def qualifyContractsAsync(
                 self._logger.warning(f"Unknown contract: {contract}")
                 result.append(None)
             elif len(detailsList) > 1:
-                possibles = [details.contract for details in detailsList]
+                # BUG FIX:
+                #  - IBKR is returning EC _and_ FOP contracts for only FOP requests,
+                #    which is clearly incorrect, so now if an input request has `secType`
+                #    defined, we only return matching `secType` contracts.
+                if contract.secType:
+                    possibles = [
+                        details.contract
+                        for details in detailsList
+                        if contract.secType == details.contract.secType  # type: ignore
+                    ]
+
+                    # if our match instrument type filter resolved to only _one_ matching
+                    # contract, then we found a single usable result to add.
+                    if len(possibles) == 1:
+                        c = possibles[0]
+                        if contract.exchange == "SMART":
+                            # Allow contracts to become more generic if SMART requested as input
+                            c.exchange = contract.exchange  # type: ignore
+
+                        util.dataclassUpdate(contract, c)
+                        result.append(contract)
+                        continue
+                else:
+                    # else, return all matches if no specific secType requested
+                    possibles = [details.contract for details in detailsList]
+
                 self._logger.warning(
                     f"Ambiguous contract: {contract}, " f"possibles are {possibles}"
                 )
+
                 if returnAll:
                     result.append(possibles)
                 else: