Potential problem with undo_ftplugin??

[dpetka2001]

Hi there. A discussion popped up in LazyVim Discussions about some keymaps not available within php files. The OP mentioned that the first buffer had the mappings but subsequent ones didn't have correct mappings. I found out this in Neovim php ftplugin, which seems to be the root of the problem.

However, setting vim.g.no_php_maps = true, just preserves the mapping on the first buffer and deletes the ones in subsequent opened buffers. Quoting here my latest observations

So, @chronon here's some things that I've observed. I use fzf-lua and observed the same thing you did even with vim.g.no_php_maps = true. But when I open 2 php files with nvim file1.php file2.php, then the mappings work fine on both buffers. If I open Neovim and restore the session where both files are open in buffers, then the mappings work as expected. When I open Neovim with one file and then open another one using Neotree, then the mappings work as expected on both buffers. I even tried switching from fzf-lua to telescope and there it also worked well.
So, from my testing I've observed that when opening a file through FzfLua files picker, then for some reason the undo_ftplugin gets triggered and that deletes the mappings in the buffers that are opened through it. I'm not 100% sure that is what happens, but from my observations this is the explanation I've come up with.

@ibhagwan Do you maybe have some insight as to why this might be happening? My deduction (which of course might be wrong) based on my observations, was that for some reason undo_ftplugin was triggered for php files and that deleted the mappings from subsequent buffers. The same thing did not happen when opening nvim file1.php file2.php or from Neotree or from Telescope or from restoring a session where both buffers happened to be restored and opened.

vim.g.no_php_maps seems to be working for other ways opening files but not with FzfLua files. Please do correct me whatever wrong observations I've made. Not sure if this is an issue/bug with FzfLua, so wanted to check about your insight in Discussions first.

[ibhagwan]

Not sure if this is an issue/bug with FzfLua, so wanted to check about your insight in Discussions first.

When it comes to these type of issues I don’t rule out anything, if I could reproduce this locally I can look into it, is installing the mentioned LSP and opening a php enough to reproduce this?

[dpetka2001]

What is the difference between fzf-tmux profile and the default one? Doesn't the fzf-tmux profile run in a terminal window?

[ibhagwan]

What is the difference between fzf-tmux profile and the default one? Doesn't the fzf-tmux profile run in a terminal window?

In this case Fzf runs in a tmux pop up as opposed to a neovim window.

[dpetka2001]

Just for clarification, but were you able to reproduce this on your end? Or is this specifically tied to LazyVim?

[ibhagwan]

Just for clarification, but were you able to reproduce this on your end? Or is this specifically tied to LazyVim?

I did not get to trying to reproduce this.

[dpetka2001]

Either way thank you for your time as always. If you want me to test further things, just say what to do in this discussion and I'll try that and give you back whatever feedback I can get from my observations.

[ibhagwan]

I'm trying to reproduce this to see what triggers this behavior, used the project of the user who opened this issue: https://github.com/chronon/cakephp-remote-files

Installed intelephense via Mason (you can see it's working in the statusline), I open a php file directly from the shell nvim src/RemoteFilesPlugin.php but I don't see the mappings for nex/prev references, also tried :LspRestart intelephense yet I only see the "bad" mapping.

What am I missing @dpetka2001 @chronon?

[ibhagwan]

@dpetka2001, can you start debugging this function and see if on_attach is getting called after opening a file from fzf-lua?

The issue is most likely here:
https://github.com/LazyVim/LazyVim/blob/2cf3d234bfc31a1a4eda282ddabc12987f762893/lua/lazyvim/util/lsp.lua#L26

[dpetka2001]

Thank you for your insight. I'll be out for the rest of the evening, but I'll try to look into it again tomorrow and try to figure out what's happening based on your latest insight. Thank you as always.

[dpetka2001]

@ibhagwan I just tried to dive into it tonight after all. Could you see my latest answer in LazyVim discussions and give your insight please? It seems that when opening a file from fzf-lua, the LspAttach event triggers when it's still terminal mode.

[dpetka2001]

@ibhagwan It has been solved after all. I want to really thank you once again for being patient and willing to look into this and provide the necessary insight and guidance, so I could find the culprit. In the end, I only managed to find out where things went wrong but not the why, but thankfully Folke took it over from there and came up with a proper solution.

Again, you are a great person and developer and really thank you, because every time I've interacted with you, you've been really helpful 😄 Greatly appreciated!!

[ibhagwan]

@ibhagwan I just tried to dive into it tonight after all. Could you see my latest answer in LazyVim discussions and give your insight please? It seems that when opening a file from fzf-lua, the LspAttach event triggers when it's still terminal mode.

That because mode changes in vim are scheduled, that’s why it takes time to switch back to normal mode and the actions are still performed in terminal mode.

I see this got solved, very nice :)

[ibhagwan]

Again, you are a great person and developer and really thank you, because every time I've interacted with you, you've been really helpful 😄 Greatly appreciated!!

Tysm for the kind words @dpetka2001 ❤️

Ty @folke for fixing this pesky issue!