How to reload :FzfLua tabs with different query by an action?

[nyngwang]

As title. The first snippet I provided below indeed updates the list, but it has two problems:

1. It "blinks", i.e. fzf-lua quickly re-opens its window. How do I avoid it?
2. I want to avoid writing require('fzf-lua').tabs({ query = ... }) directly by myself. This could be fine if opts is always nil, but what if the caller uses a very complex opts in .tabs(opts)? I need a way to fetch the original arguments, deep-copy it, modify it, and re-run the command with the modified arguments.

-- a part of the fzf-lua's `setup`.
require('fzf-lua').setup {
  'hide', -- I assume everything is run on hide-profile.
  -- ...
  actions = {
    ['ctrl-g'] = {
      fn = function (selected, opts)
        -- print(vim.inspect(opts))
        require('fzf-lua').tabs { query = ('^%d: '):format(vim.fn.tabpagenr()) }
      end,
    },
    -- ...
  }
  -- ...
}
-- The `opts` might be `nil`.
require('fzf-lua').tabs()
-- Or a complex table to fit my need.
require('fzf-lua').tabs { ... }

I did read the Wiki but I'm still confused, for example:

{
  fn = function(selected, opts)
    -- I want to get the arguments of the current command.
    local original_args = get_original_args(opts)
    -- so that I can modify it to prepare for the rerun:
    local modified_args = do_something(original_args)
    -- In the end, I will try to rerun the command variant derived from the current command
    require('fzf-lua').tabs(modified_args)
    -- Or this, since I don't know:
    get_rerun_fn(opts)(modified_args)
  end,
  reload = true, -- Since I called `fzf.tabs` above, what's the point I set `reload=true` or `require('fzf-lua').actions.resume` here?
}

I know this is a bit confusing, so let me describe a simple use case:

After calling :FzfLua tabs, I want to execute an action that will overwrite the prompt as ^{tabnr}: where {tabnr} is obtained by matching the hovered-but-not-yet-selected entry.

Reference

I have read #1626 and #499, and the Wiki-advanced section. None of these seem to mention about:

1. how to get_original_args
2. how to get_rerun_fn

I described in the second snippet above.

[nyngwang]

I just found the answer to my 2. in the file action.lua:

fzf-lua/lua/fzf-lua/actions.lua

Lines 964 to 969 in 54005a6

	M.toggle_opt = function(opts, opt_name)
	-- opts.__call_opts[opt_name] = not opts[opt_name]
	local o = vim.tbl_deep_extend("keep", { resume = true }, opts.__call_opts)
	o[opt_name] = not opts[opt_name]
	opts.__call_fn(o)
	end

Still finding the answer to avoid 1.

EDIT: both 1. and 2. are solved!

EDIT2: This is the final config, tested against 494af9d :

local pos_offset = function (tabnr)
  local pos = 1
  for i, t in ipairs(vim.api.nvim_list_tabpages()) do
    if i < tabnr then pos = pos + 1 + #vim.api.nvim_tabpage_list_wins(t) end
  end
  return pos
end

tabs = {
  fzf_opts = {
    ['--with-nth'] = '3,5..', -- show tabnr for each entry.
    -- ['--query'] = '', -- prefill.
  },
  formatter = 'path.filename_first',
  actions = {
    ['enter'] = {
      fn = function (selected, opts)
        if #selected == 0 then
          print('fzf-lua: no entry for action.')
          opts.__call_fn(vim.tbl_deep_extend('keep', {}, opts.__call_opts))
          return
        end
  
        local _, _, entry = unpack(selected, 1, 3)
  
        local tabnr, win_id = entry:match(':(%d+):(%d+)%)')
        tabnr = tonumber(tabnr) or 0
        win_id = tonumber(win_id) or 0
  
        if win_id > 0
          then vim.api.nvim_set_current_win(win_id)
          else vim.api.nvim_set_current_tabpage(tabnr)
        end
      end,
      field_index = '{q} $FZF_POS {}',
      -- reset prompt for reload. (buggy, discarded)
      -- postfix = ...
    },
    ['ctrl-g'] = {
      fn = function (selected, opts)
        -- when no match, we get `selected == {}`.
        if #selected == 0 then
          print('fzf-lua: no entry for action.')
          return
        end
  
        local query, _, entry = unpack(selected, 1, 3)
  
        if -- current scope: single tabpage.
          query:match('%^%d+:')
        then -- change scope to all tabpages, and update pos.
          local tabnr_entry = tonumber(query:match('%^(%d+):'))
          opts.__call_fn(vim.tbl_deep_extend('keep', {
            query = '',
            ['keymap.fzf.load'] = ("transform:echo 'pos(%s)'"):format(pos_offset(tabnr_entry))
          }, opts.__call_opts))
          return
        end
        -- current scope: all tabpages.
  
        local tabnr_entry = tonumber(entry:match(':(%d+):'))
        -- change scope to single tabpage, and update pos.
        opts.__call_fn(vim.tbl_deep_extend('keep', {
          query = ('^%d: '):format(tabnr_entry),
          ['keymap.fzf.load'] = "transform:echo 'pos(2)'", -- skip `tab_title` entry.
        }, opts.__call_opts))
      end,
      reload = true,
      field_index = '{q} $FZF_POS {}',
    },
    ['ctrl-b'] = actions.dummy_abort
  },
}

[nyngwang]

@ibhagwan I remembered that you said you rarely open many tabpages. But! If you have time, I sincerely invite you to try my script (albeit the code is a bit ugly, lol) here and bang some <ctrl-g> to experience the effect (I really found it useful and fun during the process). Anyway, thanks for your help, and you @phanen surely.

(In fact, this is something I want to make years ago, but back to that time I was too-afraid to implement it. Emmm... ended up with a complex thread, lol)

[phanen]

It "blinks", i.e. fzf-lua quickly re-opens its window. How do I avoid it?

with --listen

I guess it's currently impossible without --listen if you want to change query dynamically. But you can do so:

require('fzf-lua').tabs {
  fzf_opts = {
    ['--listen'] = true,
  },
  actions = {
    ['ctrl-g'] = {
      fn = function(s)
        vim.system {
          'curl',
          '-XPOST',
          ('localhost:%s'):format(assert(s[1])),
          '-d',
          ('change-query(^ %d: )'):format(vim.fn.tabpagenr()),
        }
      end,
      field_index = '$FZF_PORT',
    },
  },
}

NO --listen

require('fzf-lua').tabs {
  actions = {
    ['ctrl-g'] = {
      fn = function() end,
      exec_silent = true,
      postfix = ('transform-query:%s')
        :format('nvim -u NONE --headless --server $NVIM --remote-expr %s')
        :format(require('fzf-lua.libuv').shellescape("printf('^ %d', tabpagenr())")),
    },
  },
}

[phanen]

EDIT:
{q} $FZF_POS {2..} can skip base64.

Maybe add a clear-screen can force refresh screen

      postfix = ('transform-query(%s)+clear-screen'):format(

but query becomes nil

No... I didn't reproduce it. The query is still ^3: for me. From the code, nil can never be return.

the list doesn't refresh

Also I have no such issue.

[nyngwang]

@phanen After 494af9d, it seems that both transform-query:%s, transform-query(%s)+clear-screen can't work anymore. After I re-opened the fzf-lua window, any char I entered just overwrote the underlying char in the terminal buffer:

(hope you still have energy to debug this thread, lol)

• Expected behaviour: Since I already hit enter on the entry of hello_.c, the query should be reset to ^6: when I re-open the fzf-lua window.
• Current behaviour: When I re-opened the fzf-lua, the query was still the old one ^6: hello, and my <bs> key cannot delete anything, so I held the key f and it overwrote the original content of the terminal buffer like the screenshot shown.

[phanen]

That seems a bug. #1915

[phanen]

Even worse, sometimes the query becomes nil with the follow code (I have tried my best to prevent postfix from return nil, but it still happens):

I try your snippet again and reproduce it just now. That's because when you use ctrl-g
-> you open a new picker
-> new picker means register new functions in ring, and ring is limit-sized
-> when you run out of ring, while postfix is always passed as the same string (use the same registered fnc_id), but the function associated with fuc_id may be another function

So you didn't run your original postfix, but an random refreshed new function (when function don't return new value. It will be converted to "nil" and write to terminal stdin...

fzf-lua/lua/fzf-lua/shell.lua

Line 139 in 939a731

uv.write(pipe, tostring(ret) .. "\n", on_complete)

TLDR: then maybe always build a new string cli rather than reuse the old one...
but as ibhagwan said, this case is better rewrited in a new picker..

          opts.__call_fn(vim.tbl_deep_extend('keep', {
            query = '^ ',
            ['keymap.fzf.load'] = ("transform:echo 'pos(%s)'"):format(opts.fzf_pos_enter),
          }, vim.tbl_extend(opts.__call_opts, { actions = { enter = { fn = ..., postfix = ('transform-query:%s')... } } })))

[nyngwang]

@phanen OK, ty for the fix in #1915 and the analysis. Maybe ctrl-g is the culprit, but I remember that to reproduce the nil-bug I didn't press ctrl-g many times even without pressing it at all. Anyway, I'm now fine with the solution without postfix.

[nyngwang]

@ibhagwan So, long story short, I want to achieve the following sequence of events:

I press enter --> fzf-lua hide, jump to the selected buffer --> update fzf-lua's query --> fzf-lua unhide, I can start from the updated query

While @phanen has helped me a lot, but the way facilitating postfix = ... ended up very tricky on my side (I did reproduce it with a minimal.lua, but I rather check for the right direction with you first.) So I think this is a proper timing to ask for your help, otherwise I don't know what to do to complete this thread. (my self-answer above does not include this feature.)

The following code is a workaround to simulate the sequence of events above, but the only problem is that I make use of opts.__call_fn to:

1. re-open fzf-lua window with an updated query. (NOTE1 in the following code)
2. send a key to normal mode to hide fzf-lua. (NOTE2 in the following code)

So I ended up having a not-perfect sequence of events:

I press enter --> fzf-lua hide, jump to the selected buffer --> unhide fzf-lua with updated query --> hide fzf-lua with --> fzf-lua unhide, I can start from the updated query

But "unhide fzf-lua with updated query --> hide fzf-lua with " creates a "blink", i.e. there is an extra pair of unhide-hide.

I really like to achieve the first sequence of events I pointed out. Do you have any idea how to do that?

NOTE regarding "why" this feature: After my pressing 'enter', the current buffer will become {buf_name} by the query ^{tabnr}: {buf_name}. But to start the next search under the same {tabnr}, I have to delete {buf_name} anyway. So I decide to implement this feature so this process can be automated.

actions = {
  ['enter'] = {
    fn = function (selected, opts)
      if #selected == 0 then
        print('fzf-lua: no entry for action.')
        return
      end

      local _, _, entry = unpack(selected, 1, 3)

      local tabnr, win_id = entry:match(':(%d+):(%d+)%)')
      tabnr = tonumber(tabnr) or 0
      win_id = tonumber(win_id) or 0

      if win_id > 0
        then vim.api.nvim_set_current_win(win_id)
        else vim.api.nvim_set_current_tabpage(tabnr)
      end

      -- NOTE1: I want to update the query to `^{tabnr}: `, but `opts.__call_fn` reopen the fzf-lua window.
      opts.__call_fn(vim.tbl_deep_extend('keep', {
        query = ('^%d: '):format(tabnr),
        -- ['keymap.fzf.load'] = ("transform:echo 'pos(%s)'"):format(pos_offset(tabnr_entry))
      }, opts.__call_opts))
      -- NOTE2: So I close it with a feedkey <Esc>.
      vim.api.nvim_feedkeys('�', 'n', true)
    end,
    field_index = '{q} $FZF_POS {}',
    -- reset prompt for reload. (buggy, can't work)
    -- postfix = ...
  },

[ibhagwan]

Maybe try a different approach, drop the customization and just restart the interface with your updated query like so :FzfLua tabs query=…?

Otherwise, IMHO, it’s an overly complex customization.

[ibhagwan]

Btw, if you’re already going in the route of complicated niche customization I’d just build my own picker, copy the tabs code and make the interface be exactly what you want instead of trying to bend tabs to your will, easier and the result will be better for you as well.

[nyngwang]

@ibhagwan My original way idea was similar to yours: the same code as above but without the code under both NOTE1 and NOTE2. This way, whenever I need to search yet another buffer under the same {tabnr}, I just manually to delete-word then type the new {buf_name}. Ty for your feedback, I was too obsessed by "trying to fix it" recently.