file_switch_or_edit and buf_switch_or_edit only switches within the current window/tab?

[dominickng]

Hi, just trying to work out how these options work. Forgive me if I'm misunderstanding them. :)

Let's say I have a.ts and b.ts open in a split in a tab, and c.ts open in a second tab:

Tab 1          Tab 2
a.ts | b.ts    c.ts

Let's say I run fzf-lua files in Tab 1 to find b.ts while focused on a.ts, and run actions.file_switch_or_edit on the result. This behaves as I expect: it changes focus to the split with b.ts.

But if I run fzf-lua files in Tab 1 to find c.ts, I'd expect actions.file_switch_or_edit to focus tab 2 and c.tsthere. Instead, it opensc.ts` in Tab 1 in the currently focused split.

Running fzf-lua tabs makes this behave as I expect (focus the tab/split if the file is already open and visible), but this means I can't open files I don't have open. I'd need to run fzf-lua tabs, find that I don't have a file open, then run fzf-lua files to find the file and open it.

Is there a way to combine these behaviours? Focus the existing open split if a file is already opened, and if it's not opened, open the file? I also want to accomplish this for the tabedit, split, and vsplit options. I've tried the following, but it exhibits the same behaviour as described above:

            ["ctrl-t"] = function(selected, opts)
              if not actions.file_switch(selected, opts) then
                actions.file_tabedit(selected, opts)
              end
            end,

Looking at the implementation, maybe this requires a tabs + files command where tabs are preferred and it falls back to files if not found?

[nenahp]

I know there's a :drop cmd... Maybe that's what you want?

[nenahp]

I test a bit, I think it work well:

          ['enter'] = function(sel, o)
            local entry = require('fzf-lua.path').entry_to_file(sel[1], o, o._uri)
            local fullpath = entry.bufname or entry.uri and entry.uri:match("^%a+://(.*)") or entry.path
            vim.cmd(([[drop %s]]):format(fullpath))
          end,

[ibhagwan]

I test a bit, I think it work well:

          ['enter'] = function(sel, o)
            local entry = require('fzf-lua.path').entry_to_file(sel[1], o, o._uri)
            local fullpath = entry.bufname or entry.uri and entry.uri:match("^%a+://(.*)") or entry.path
            vim.cmd(([[drop %s]]):format(fullpath))
          end,

Interesting, TIL about :drop, Ty @nenahp!

[dominickng]

Brilliant, thanks! TIL about :drop as well as :tab drop to do the same thing but open in new tab rather than current buffer. This was the hint I needed to get the following behaviour for <Enter>, <Ctrl-t>, <Ctrl-s>, and <Ctrl-v>: jump to the buffer if it's open already, or opens the file in the (current buffer|new tab|split|vertical split) if it's not, which is exactly the behaviour I wanted. Config as follows:

      local OutType = {
        OPEN = {},
        NEW_TAB = {}
      }

      -- fzf action which switches to the selected file if it's already open
      -- (using the builtin :drop command), otherwise opens the file. If
      -- OutType is NEWTAB, also passes the :tab option to open in a new tab
      -- rather than current buffer
      local switch_or_drop = function(selected, opts, outtype)
        local entry = require('fzf-lua.path').entry_to_file(selected[1], opts, opts._uri)
        local fullpath = entry.bufname or entry.uri and entry.uri:match("^%a+://(.*)") or entry.path
        local command = (outtype == OutType.NEW_TAB) and "tab drop" or "drop"
        vim.cmd(([[silent %s %s]]):format(command, fullpath))
      end

      -- fzf action which switches to the selected file if it's already open
      -- (using the builtin :sbuffer command), otherwise calls `fallback`.
      local switch_or_fallback = function(selected, opts, fallback)
        local entry = require('fzf-lua.path').entry_to_file(selected[1], opts, opts._uri)
        local fullpath = entry.bufname or entry.uri and entry.uri:match("^%a+://(.*)") or entry.path
        if vim.fn.bufwinid(fullpath) == -1 then
          fallback(selected, opts)
        else
          vim.cmd(([[silent sbuffer %s]]):format(fullpath))
        end
      end

      fzf.setup({
        actions = {
          -- applies to files and buffers commands
          files = {
            true, -- inherit defaults
            ["enter"] = function(selected, opts)
              switch_or_drop(selected, opts, OutType.OPEN);
            end,
            ["ctrl-t"] = function(selected, opts)
              switch_or_drop(selected, opts, OutType.NEW_TAB);
            end,
            ["ctrl-v"] = function(selected, opts)
              switch_or_fallback(selected, opts, fzf.actions.file_vsplit)
            end,
            ["ctrl-s"] = function(selected, opts)
              switch_or_fallback(selected, opts, fzf.actions.file_split)
            end,
          },
        },
       })

[ibhagwan]

Brilliant, thanks! TIL about :drop as well as :tab drop to do the same thing but open in new tab rather than current buffer. This was the hint I needed to get the following behaviour for , , , and : jump to the buffer if it's open already, or opens the file in the (current buffer|new tab|split|vertical split) if it's not. This is exactly the behaviour I wanted. Config as follows:

Lean and clean solution, very nice @dominickng!

[ibhagwan]

Btw, you can drop actions.buffers table altogether as actions.files rules over everything since I unified the actions in 5bd319c, buffer actions are just symlinks:

fzf-lua/lua/fzf-lua/actions.lua

Lines 411 to 419 in 34de854

	M.buf_edit = M.file_edit
	M.buf_split = M.file_split
	M.buf_vsplit = M.file_vsplit
	M.buf_tabedit = M.file_tabedit
	M.buf_sel_to_qf = M.file_sel_to_qf
	M.buf_sel_to_ll = M.file_sel_to_ll
	M.buf_edit_or_qf = M.file_edit_or_qf
	M.buf_switch = M.file_switch
	M.buf_switch_or_edit = M.file_switch_or_edit

[dominickng]

Ah, that's helpful to know. Will drop the buffer table (and edit above to match). Thanks!