Files command not honoring fzf_opts

[zeta-squared]

I have the following config for fzf-lua

local fzflua = require('fzf-lua')

fzflua.setup({
	fzf_opts = {
		['--layout'] = 'default',
	},
	keymap = {
		builtin = {
			true,
			["<C-k>"] = "preview-page-up",
			["<C-j>"] = "preview-page-down",
			["<C-i>"] = "preview-up",
			["<C-u>"] = "preview-down",
            ["<C-[>"] = "hide",
		},
	},
	files = {
		true,
		rg_opts = [[--color=never --files --hidden --follow -g "!.git" -g "!node_modules" -g "!venv" -g "!__pycache__"]],
	},
	grep = {
		true,
		rg_opts = [[-g "!.git" -g "!node_modules" -g "!venv" -g "!__pycache__" --column --line-number --no-heading --color=always --smart-case --max-columns=4096 -e]],
	},
})

vim.keymap.set('n', '<leader>pf', fzflua.files)
vim.keymap.set('n', '<leader>pb', fzflua.buffers )
vim.keymap.set('n', '<leader>pt', fzflua.tabs)
vim.keymap.set('n', '<leader>pr', fzflua.grep_visual)
vim.keymap.set('n', '<leader>pq', fzflua.lines)
vim.keymap.set('n', '<leader>pl', fzflua.blines)
vim.keymap.set('n', '<leader>pc', fzflua.git_commits)
vim.keymap.set('n', '<leader>pg', fzflua.git_status)

I purposely set --layout to default because I like the search bar at the bottom. Strangely thought his works with all the commands I use except for files. Everytime I use files the reverse layout is used. Has anyone come across this issue? or does anyone have any suggestions of where to look for a solution?

Ironically if I run lua require('fzf-lua').setup({fzf_opts={['--layout'] = 'default'}}) in neovim cmdline then files works as expected so I guess somewhere along the line the --layout config is not being passed from my lua file?

[ibhagwan]

Ironically if I run lua require('fzf-lua').setup({fzf_opts={['--layout'] = 'default'}}) in neovim cmdline then files works as expected so I guess somewhere along the line the --layout config is not being passed from my lua file?

You’ve answered this yourself, your config file most likely isn’t being loaded.

[ibhagwan]

Ok, so it is the files part of my config. This is strange though because on my local machine that doesn't cause any issues. The above issue only occurs on a devcontainer.

Why do you have true as the first index under files and grep? It is not required, maybe in a weird way this is causing the issue?

[zeta-squared]

Ok, so it is the files part of my config. This is strange though because on my local machine that doesn't cause any issues. The above issue only occurs on a devcontainer.

Why do you have true as the first index under files and grep? It is not required, maybe in a weird way this is causing the issue?

I must have confused the config with another plugin but I thought true keeps all the default options and changes only those that are listed. Was this how the config worked in a previous version or have I adopted this by mistake from another plugin?

[ibhagwan]

I must have confused the config with another plugin but I thought true keeps all the default options and changes only those that are listed. Was this how the config worked in a previous version or have I adopted this by mistake from another plugin?

This how inheriting key map defaults works in this plugin, but only the key maps, rest of the defaults are kept regardless.

[zeta-squared]

Fair enough. That was an error on my part.

For record, if anyone encounters such a bug note that the solution here was a user error and true should not have been part of my files and grep config options.

[ibhagwan]

Fair enough. That was an error on my part.

For record, if anyone encounters such a bug note that the solution here was a user error and true should not have been part of my files and grep config options.

In any event this shouldn’t have happened, fixed in fe71a7c.