Implement jump to line after opening a file if the file search string ends with colon and a whole number (e.g :<int>)

[asfaltboy]

I see that we have an issue where colon is preventing matches (see discussion)... I wonder if we could correct this issue, and at the same time enable jumping to the line in preview and upon opening the file.

Opening a file at a given line is a pretty common requirement when working with logs or errors, and for me personally this sort of feature has a high impact.

Note: telescope implements this like so: nvim-telescope/telescope.nvim#2791

[nenahp]

Like this? #1834

You can open file first then :123<cr>/123gg to jump to the line.

A plugin peek line on current buffer https://github.com/nacro90/numb.nvim.

[ibhagwan]

I’ve answered this type of request numerous times, won’t happen unless some upstream changes are implemented.

[ibhagwan]

It's already possible, just bind transform-search:<search_query> on change. Did you try #1834 (comment)? @asfaltboy

Although if you want to make pasting random fullpath work you also need customize zero event.

@phanen, I’ll have to look into what you did there, maybe transform-search is the answer here, I somehow missed it’s existence.

[ibhagwan]

@phanen, I can’t test ATM but reading the man I think this can be done by setting opts.keymap.fzf.change = "transform-search:<fzf-lua shell action>" (better use : here instead of () so this has its own --bind arg), this way we don’t need all the other hacks and external utilities like cut so this can work cross platform.

The reason I prefer :

fzf-lua/lua/fzf-lua/core.lua

Lines 648 to 653 in 9a1f4b6

	-- Separate "transform|execute|execute-silent" binds to their own `--bind` argument, this
	-- way we can use `transform:...` and not be forced to use brackets, i.e. `transform(...)`
	-- this enables us to use brackets in the inner actions, e.g. "zero:transform:rebind(...)"
	if action:match("transform")
	or action:match("execute")
	or action:match("reload")

[nenahp]

IIRC fzf support this syntax, prefix with + means it will concat with previous bind, so it's possible to eliminate (...)

fzf --bind "ctrl-r:unbind:..." --bind "ctrl-r:+execute-silent:..." --bind "ctrl-r:+clear-selection"

EDIT:
Here is the context junegunn/fzf#4019. execute(cmd) can cause unavoidable escape problem.

[ibhagwan]

IIRC fzf support this syntax, prefix with + means it will concat with previous bind, so it's possible to eliminate (...)

I had no idea, it is def worthwhile to eliminate the (…)

[nenahp]

I had no idea, it is def worthwhile to eliminate the (…)

The only limit of (...) I know is the query cannot contain ,). It's not easy to trigger an edge case. Since in fzf-lua it's only possible to reproduce by explicitly using query = "xx".

The usage case for me is to launch picker in visual mode and pass visual text to it. This can be simply fixed by convert ,) to \,). I just did it before passing query then this never happened to me again.

[ibhagwan]

Quick proof of concept using transform-search, ty @phanen!

Still without the previewer hack:

require("fzf-lua").files({
  keymap = {
    fzf = {
      change = "transform-search:" .. FzfLua.shell.raw_action(function(q, _, _)
        q = q[1]:gsub(":%d*$", "")
        return q
      end, "{q}")
    }
  },
  actions = {
    enter = function(sel, opts)
      local line = opts.last_query:match(":%d+$")
      if line then sel[1] = sel[1] .. line end
      FzfLua.actions.file_edit(sel, opts)
    end
  },
})

[ibhagwan]

Try out https://github.com/ibhagwan/fzf-lua/tree/line_query with:

:FzfLua files line_query=true

Notes:

• Previewer is WIP (doesn’t trigger when first entering line, no cursor hl)
• Maybe better naming (unsure if line_query is clear)
• Safeguard on conflicting pickers (live grep, non files, etc)

Probably not much more work is needed for this but I’m on a plane and it’s been painful over ssh lol

[ibhagwan]

I had to update fzf to be >= 0.59, so if we add this change to master, we should mention that required version for this feature.

I’ll also add a proper warning when enabled and fzf version doesn’t meet the requirements.

I also noticed the preview centers around the selected line, that's also awesome! One tine improvement we could do is to highlight that line, so it's easier to locate quickly in the preview. Not sure if this is already supported or not I think that's in your first point in notes above

As I wrote in my comment previewer needs a bit more work.

[ibhagwan]

@asfaltboy, pull rebase the branch and try again, highlights should work.

[ibhagwan]

@phanen, any comments/improvements are welcome :)

[ibhagwan]

FYI, merged to main.
8cdf9aa

[asfaltboy]

Sorry for slow response. I tested the new release, and it works great, thanks again 🙇 🎸