Remove import statements

[jelgerjansen]

The model IBPSA/Electrical/PhaseSystems/package.mo contains two import statements:

  import      Modelica.Units.SI;
  import Modelica.Constants.pi;

I propose to remove these two import statements (as they are typically not used in the library) and provide an explicit path for the SI Units in the following models (output of "grep" command):

Electrical/PhaseSystems/ThreePhase_d.mo:8:    input SI.Voltage V "system voltage";
Electrical/PhaseSystems/ThreePhase_d.mo:9:    input SI.Angle phi = 0 "phase angle";
Electrical/PhaseSystems/ThreePhase_d.mo:10:    output SI.Voltage v[n] "phase to neutral voltages";
Electrical/PhaseSystems/ThreePhase_d.mo:19:    input SI.Voltage v[n];
Electrical/PhaseSystems/ThreePhase_d.mo:20:    output SI.Voltage V;

If desired, this issue could also be used to remove the other remaining (and undesired?) import statements:

Controls/SetPoints/OccupancySchedule.mo:98:  import Modelica;
Controls/SetPoints/OccupancySchedule.mo:110:  import Modelica;
Electrical/PhaseSystems/package.mo:5:  import Modelica.Constants.pi;
Fluid/Actuators/Dampers/MixingBox.mo:9:  import Modelica.Constants;
Fluid/BaseClasses/ActuatorFilter.mo:4:  import Modelica.Blocks.Types.Init;
Fluid/Storage/BaseClasses/PartialStratified.mo:6:  import Modelica.Fluid.Types;
Fluid/Storage/BaseClasses/PartialStratified.mo:7:  import Modelica.Fluid.Types.Dynamics;

[mwetter]

@jelgerjansen : Removing all these import statements would be good.

[hcasperfu]

Another instance of an import statement that jumps to the top of my mind is

modelica-ibpsa/IBPSA/Fluid/Movers/BaseClasses/FlowMachineInterface.mo

Line 6 in 39e6e11

import cha = IBPSA.Fluid.Movers.BaseClasses.Characteristics;

[jelgerjansen]

I found some other import statements using the "grep" command. I removed all import statements and updated those models if necessary (see #1963)

[jelgerjansen]

I had to add import Modelica; statements again to IBPSA/Control/Setpoints/OccupancySchedule.mo as this model defines two encapsulated functions, and not having the import statement results in the following (Dymola 2025x) error:

Encapsulation of IBPSA.Controls.SetPoints.OccupancySchedule.switchReal
prevented us from finding Modelica in global scope.

Missing base class Modelica.Icons.Function
the class Modelica.Icons.Function exists, but Modelica is case-sensitive and uses scoping
File: C:/Users/u0132350/Documents/GIT/modelica-ibpsa/IBPSA/Controls/SetPoints/OccupancySchedule.mo, line 106
Component context: IBPSA.Controls.SetPoints.OccupancySchedule.switchReal
Component declared as OccupancySchedule occSch in IBPSA.Controls.OBC.Utilities.Validation.OptimalStartHeating

However, the import statement is only required for extend Modelica.Icons.Function;. Therefore, removing both lines also solves the issue, but removes the function icon when opening the encapsulated functions switchReal and switchInteger.
@mwetter I'm not sure which of both options you prefer?

[mwetter]

As these functions are protected, they are not showing anyway if a user browse the library. So not having the icon is fine with me.