Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed assignment of parameter that no longer exits in SolarCollector example #1969

Merged
merged 2 commits into from
Feb 12, 2025
+14 −5
Merged

Removed assignment of parameter that no longer exits in SolarCollector example #1969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18a13ed
Removed assignment of parameter that no longer exits
mwetter Feb 11, 2025
83f737a
Remove obsolete whitespace
jelgerjansen Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ env:
- TEST_ARG="make test-openmodelica PACKAGE=\"IBPSA.{Examples,Experimental}\""
- TEST_ARG="make test-dymola PACKAGE=\"IBPSA.Fluid.{Actuators,BaseClasses,Chillers,Delays,Geothermal,Examples,FMI,FixedResistances}\""
- TEST_ARG="make test-openmodelica PACKAGE=\"IBPSA.Fluid.{Actuators,BaseClasses,Chillers,Delays,Geothermal,Examples,FMI,FixedResistances}\""
- TEST_ARG="make test-dymola PACKAGE=\"IBPSA.Fluid.{HeatExchangers,HeatPumps,Humidifiers,Interfaces,MassExchangers,MixingVolumes,Movers,Sensors,Sources,Storage}\""
- TEST_ARG="make test-openmodelica PACKAGE=\"IBPSA.Fluid.{HeatExchangers,HeatPumps,Humidifiers,Interfaces,MassExchangers,MixingVolumes,Movers,Sensors,Sources,Storage}\""
- TEST_ARG="make test-dymola PACKAGE=\"IBPSA.Fluid.{HeatExchangers,HeatPumps,Humidifiers,Interfaces,MassExchangers,MixingVolumes,Movers,SolarCollectors,Sensors,Sources,Storage}\""
- TEST_ARG="make test-openmodelica PACKAGE=\"IBPSA.Fluid.{HeatExchangers,HeatPumps,Humidifiers,Interfaces,MassExchangers,MixingVolumes,Movers,SolarCollectors,Sensors,Sources,Storage}\""
- TEST_ARG="make test-dymola PACKAGE=\"IBPSA.ThermalZones\""
- TEST_ARG="make test-openmodelica PACKAGE=\"IBPSA.ThermalZones\""
- TEST_ARG="make test-dymola PACKAGE=\"IBPSA.{Airflow,BoundaryConditions,Controls,Electrical}\""
Expand Down
15 changes: 12 additions & 3 deletions IBPSA/Fluid/SolarCollectors/Validation/EN12975_Array.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,19 @@ model EN12975_Array
nPanels=4,
nSeg=3,
sysConfig=IBPSA.Fluid.SolarCollectors.Types.SystemConfiguration.Array,
nPanelsSer=2,
nPanelsPar=2)
"Flat plate solar collector model, has been modified for validation purposes"
annotation (Placement(transformation(extent={{-20,20},{0,40}})));

Collector solCol1(nSeg=3, nPanels=2)
Collector solCol1(
nSeg=3,
nPanels=2)
"Flat plate solar collector model, has been modified for validation purposes"
annotation (Placement(transformation(extent={{-50,-40},{-30,-20}})));

Collector solCol2(nSeg=3, nPanels=2)
Collector solCol2(
nSeg=3,
nPanels=2)
"Flat plate solar collector model, has been modified for validation purposes"
annotation (Placement(transformation(extent={{-50,-80},{-30,-60}})));

Expand Down Expand Up @@ -147,6 +150,12 @@ Furthermore, the pressure drops over all models should be the same.
</html>", revisions="<html>
<ul>
<li>
February 11, 2025, by Michael Wetter:<br/>
Removed parameter assignment for parameter that no longer exists.<br/>
This is for
<a href=\"https://github.com/ibpsa/modelica-ibpsa/issues/1968\">IBPSA, #1968</a>.
</li>
<li>
February 27, 2024, by Jelger Jansen:<br/>
First implementation.<br/>
This is for
Expand Down
Loading