-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18 search improvements #27
Draft
patrick-austin
wants to merge
93
commits into
master
Choose a base branch
from
18_search_improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps `luceneVersion` from 5.3.0 to 8.6.0. Updates `lucene-core` from 5.3.0 to 8.6.0 Updates `lucene-queryparser` from 5.3.0 to 8.6.0 Updates `lucene-analyzers-common` from 5.3.0 to 8.6.0 Updates `lucene-join` from 5.3.0 to 8.6.0 Signed-off-by: dependabot[bot] <support@github.com>
…n-8.6.0 Dependabot/maven/lucene version 8.6.0 into 18
In addition to the smaller stuff (use of
|
VKTB
reviewed
Oct 3, 2022
VKTB
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers a variety of improvements to free text search functionality.
Closes #18 #19 #25 #26 #30
Functional changes
Added the ability to:
searchAfter
parametertext
field into more specific fields that reflect the ICAT schema to allow field targettingParameter
sArchitectural changes
In addition to changes to various functions on the main
Lucene
class:DocumentMapping
FacetedDimension
to store the results of a request to facet the documentsSearch
fromLucene
into its own dedicatedSearchBucket
class to handle building of complex queries and additional searching parameters (e.g. sorting)ShardBucket
added alongsideIndexBucket
inLucene
to reflect the distinction between a single directory of Lucene Documents (ShardBucket
) and a way to access all Documents of one entity type contained in one or more directories (IndexBucket
)Interdependencies on other components