Skip to content

WGFAST2025_demo.ipynb #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmjech opened this issue Apr 3, 2025 · 1 comment
Open

WGFAST2025_demo.ipynb #36

jmjech opened this issue Apr 3, 2025 · 1 comment

Comments

@jmjech
Copy link
Collaborator

jmjech commented Apr 3, 2025

The demo works well and is a good representation of echoSMs.
One minor issue is that when I use the command to plot the cod fish body and swimbladder outlines (echosms.KRMdata().model('Cod').plot()), the snout of the fish is at ~400 mm instead of at 0 mm - i.e., both the swimbladder and fish body are flipped horizontally (it's good that both are flipped rather than only one). I think we should keep the convention that 0 is the furthest anterior point of the digital data. I think I saw a plot generated by you where the snout was at 0, so I wonder if the coordinate system of the plot needs to be defined?

@gavinmacaulay
Copy link
Collaborator

I noticed yesterday that the KRM shapes were not following the echoSMs coordinate system convention (head was towards -ve x direction instead of +x) so I flipped the data (new_x = max(old_x) - old_x). Adding the convention of having the furtherest anterior point at x=0 means that the rest of the body will have negative x coordinates - a minor inconvenience. Or for plotting we can invert the x-axis but this has the side effect of changing which side of the organism is facing the viewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants