-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Particle Type errors into a warning and a NotImplementedError #656
Merged
Merged
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
72958e5
New ParticleTypeWarning as parent class
tjlaboss 228272f
Treat ParticleType exceptions as warnings
tjlaboss a159e8c
Convert test_importance.py from unittest to pytest
tjlaboss 63ab5ee
Unit test for warning, not error
tjlaboss 92f7917
Format everything with Black.
tjlaboss a18585b
Update changelog
tjlaboss b343454
Make default importance a NotImplementedError
tjlaboss e90c5a3
Test the new NotImplementedError
tjlaboss 9d476b9
oops forgot to commit the file
tjlaboss 40fed32
Give the test a more descriptive name.
tjlaboss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
A test with a default importance (Not Implemented) | ||
C cells | ||
c | ||
1 1 20 | ||
-1000 $ dollar comment | ||
U=350 trcl=5 | ||
imp:n,p=1 $ imp:e should default to 1 | ||
2 2 8 | ||
-1005 | ||
imp:n,p=1 $ imp:e should default to 1 | ||
3 3 -1 | ||
1000 1005 -1010 | ||
imp:n=3 $ imp:e and imp:p should default to 1 | ||
99 0 | ||
1010 | ||
imp:n=9 $ imp:e should default to 1 | ||
imp:p=0 | ||
5 0 | ||
#99 | ||
imp:n=0 $ imp:e should default to 0 | ||
imp:p=0 | ||
c foo end comment | ||
|
||
C surfaces | ||
1000 SO 1 | ||
1005 RCC 0 1.5 -0.5 0 0 1 0.25 | ||
1010 SO 3 | ||
|
||
C data | ||
C materials | ||
C UO2 5 atpt enriched | ||
m1 92235.80c 5 & | ||
92238.80c 95 | ||
C Iron | ||
m2 26054.80c 5.85 | ||
26056.80c 91.75 | ||
26057.80c 2.12 | ||
26058.80c 0.28 | ||
C water | ||
m3 1001.80c 2 | ||
8016.80c 1 | ||
MT3 lwtr.23t | ||
C execution | ||
ksrc 0 0 0 | ||
kcode 100000 1.000 50 1050 | ||
phys:p j 1 2j 1 | ||
mode n p e | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switch to a more meaningful test name. I am going to be so confused by this in the future. Maybe:
test_not_implement_on_export