added error when executable crashes #30341

lynnmunday · 2025-04-16T17:05:59Z

closes #30340

moosebuild · 2025-04-16T19:53:05Z

Job Documentation, step Docs: sync website on e3eaf0b wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild · 2025-04-16T20:43:10Z

Job Coverage, step Generate coverage on e3eaf0b wanted to post the following:

Framework coverage

	41d1ea	#30341 e3eaf0
	Total	Total	+/-	New
Rate	85.43%	85.43%	-0.00%	-
Hits	112330	112329	-1	0
Misses	19156	19157	+1	0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

dschwen · 2025-04-16T21:13:38Z

python/TestHarness/util.py

+    try:
+        output = runCommand("%s --show-capabilities" % exe)
+    except:
+        print("Error! Executable crashed.")
+        exit(1)
+


You could put this try/catch into runCommand...

I didn't know how to put a try catch on subprocess.Popen, I don't think it fails.

def runCommand(cmd, cwd=None): # On Windows it is not allowed to close fds while redirecting output should_close = platform.system() != "Windows" p = subprocess.Popen(cmd, cwd=cwd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, close_fds=should_close, shell=True) output = p.communicate()[0].decode('utf-8') if (p.returncode != 0): output = 'ERROR: ' + output return output

I'm assuming what fails is the communicate(). Something must be throwing the exception in there, otherwise there'd be nothing to catch in getCapabilities...

I was wrong, I wasn't catching the exception. I pasted in the error messages below. I added some extra output to the exception that has always been raised.

lynnmunday · 2025-04-18T20:08:02Z

This is was the old error message I got when the executable segfaults with --show-capabilities

(moose) INL621590:porous_flow mundlb$ rt
Traceback (most recent call last):
  File "/Users/mundlb/projects/moose/python/TestHarness/util.py", line 716, in parseMOOSEJSON
    output = output.split('**START JSON DATA**\n')[1]
IndexError: list index out of range

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/mundlb/projects/moose/modules/porous_flow/./run_tests", line 8, in <module>
    TestHarness.buildAndRun(sys.argv, None, MOOSE_DIR)
  File "/Users/mundlb/projects/moose/python/TestHarness/TestHarness.py", line 231, in buildAndRun
    harness = TestHarness(argv, moose_dir, moose_python_dir, test_root)
  File "/Users/mundlb/projects/moose/python/TestHarness/TestHarness.py", line 311, in __init__
    self.options._capabilities = util.getCapabilities(self.executable)
  File "/Users/mundlb/projects/moose/python/TestHarness/util.py", line 532, in getCapabilities
    return parseMOOSEJSON(output, '--show-capabilities')
  File "/Users/mundlb/projects/moose/python/TestHarness/util.py", line 724, in parseMOOSEJSON
    raise Exception(output_string)
Exception:  Failed to find JSON header and footer from --show-capabilities

With this change it will show any errors the executable might have produced and the exception:

(moose) INL621590:porous_flow mundlb$ rt
Traceback (most recent call last):
  File "/Users/mundlb/projects/moose/python/TestHarness/util.py", line 716, in parseMOOSEJSON
    output = output.split('**START JSON DATA**\n')[1]
IndexError: list index out of range

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/Users/mundlb/projects/moose/modules/porous_flow/./run_tests", line 8, in <module>
    TestHarness.buildAndRun(sys.argv, None, MOOSE_DIR)
  File "/Users/mundlb/projects/moose/python/TestHarness/TestHarness.py", line 231, in buildAndRun
    harness = TestHarness(argv, moose_dir, moose_python_dir, test_root)
  File "/Users/mundlb/projects/moose/python/TestHarness/TestHarness.py", line 311, in __init__
    self.options._capabilities = util.getCapabilities(self.executable)
  File "/Users/mundlb/projects/moose/python/TestHarness/util.py", line 532, in getCapabilities
    return parseMOOSEJSON(output, '--show-capabilities')
  File "/Users/mundlb/projects/moose/python/TestHarness/util.py", line 724, in parseMOOSEJSON
    raise Exception(output_string)
Exception:
ERROR: dyld[67113]: symbol not found in flat namespace '__ZN39PorousFlowPermeabilityKozenyCarmanTemplILb0EE19computeQpPropertiesEv'
Failed to find JSON header and footer from --show-capabilities

I think this would have helped me find my error.

moosebuild · 2025-04-18T20:57:42Z

Job Python 3.11 on 61de797 : invalidated by @lynnmunday

moosebuild · 2025-04-21T15:00:54Z

Job Modules parallel on 61de797 : invalidated by @lynnmunday

navierstokes distributed failed

moosebuild · 2025-04-21T17:43:57Z

Job Coverage, step Verify coverage on 61de797 wanted to post the following:

The following coverage requirement(s) failed:

Failed to generate chemical_reactions coverage rate (required: 92.0%)
Failed to generate contact coverage rate (required: 87.0%)
Failed to generate electromagnetics coverage rate (required: 94.0%)
Failed to generate external_petsc_solver coverage rate (required: 84.0%)
Failed to generate fluid_properties coverage rate (required: 84.0%)
Failed to generate fsi coverage rate (required: 85.0%)
Failed to generate functional_expansion_tools coverage rate (required: 81.0%)
Failed to generate geochemistry coverage rate (required: 96.0%)
Failed to generate heat_transfer coverage rate (required: 87.0%)
Failed to generate level_set coverage rate (required: 85.0%)
Failed to generate misc coverage rate (required: 32.0%)
Failed to generate navier_stokes coverage rate (required: 77.0%)
Failed to generate optimization coverage rate (required: 86.0%)
Failed to generate peridynamics coverage rate (required: 77.0%)
Failed to generate phase_field coverage rate (required: 85.0%)
Failed to generate porous_flow coverage rate (required: 95.0%)
Failed to generate ray_tracing coverage rate (required: 93.0%)
Failed to generate rdg coverage rate (required: 63.0%)
Failed to generate reactor coverage rate (required: 90.0%)
Failed to generate scalar_transport coverage rate (required: 81.0%)
Failed to generate solid_mechanics coverage rate (required: 84.0%)
Failed to generate solid_properties coverage rate (required: 83.0%)
Failed to generate stochastic_tools coverage rate (required: 88.0%)
Failed to generate subchannel coverage rate (required: 87.0%)
Failed to generate thermal_hydraulics coverage rate (required: 88.0%)
Failed to generate xfem coverage rate (required: 80.0%)

moosebuild · 2025-04-21T19:23:31Z

Job Coverage, step Verify coverage on 61de797 wanted to post the following:

The following coverage requirement(s) failed:

Failed to generate chemical_reactions coverage rate (required: 92.0%)
Failed to generate contact coverage rate (required: 87.0%)
Failed to generate electromagnetics coverage rate (required: 94.0%)
Failed to generate external_petsc_solver coverage rate (required: 84.0%)
Failed to generate fluid_properties coverage rate (required: 84.0%)
Failed to generate fsi coverage rate (required: 85.0%)
Failed to generate functional_expansion_tools coverage rate (required: 81.0%)
Failed to generate geochemistry coverage rate (required: 96.0%)
Failed to generate heat_transfer coverage rate (required: 87.0%)
Failed to generate level_set coverage rate (required: 85.0%)
Failed to generate misc coverage rate (required: 32.0%)
Failed to generate navier_stokes coverage rate (required: 77.0%)
Failed to generate optimization coverage rate (required: 86.0%)
Failed to generate peridynamics coverage rate (required: 77.0%)
Failed to generate phase_field coverage rate (required: 85.0%)
Failed to generate porous_flow coverage rate (required: 95.0%)
Failed to generate ray_tracing coverage rate (required: 93.0%)
Failed to generate rdg coverage rate (required: 63.0%)
Failed to generate reactor coverage rate (required: 90.0%)
Failed to generate scalar_transport coverage rate (required: 81.0%)
Failed to generate solid_mechanics coverage rate (required: 84.0%)
Failed to generate solid_properties coverage rate (required: 83.0%)
Failed to generate stochastic_tools coverage rate (required: 88.0%)
Failed to generate subchannel coverage rate (required: 87.0%)
Failed to generate thermal_hydraulics coverage rate (required: 88.0%)
Failed to generate xfem coverage rate (required: 80.0%)

lynnmunday · 2025-04-22T16:54:56Z

@dschwen Will you review and merge?

lynnmunday · 2025-04-22T17:57:21Z

The latest commit will only show:

(moose) INL621590:poroperm mundlb$ rt
Error! Executable crashed running --show-capbilities.

closes idaholab#30340

dschwen · 2025-04-23T02:08:52Z

python/TestHarness/util.py

+    if output.startswith("ERROR"):
+        print("Error! Executable crashed running --show-capbilities.")
+        exit(1)


No, that's not right. You might get a crash without the ERROR string.

This is right, you get an ERROR whenever the executable crashes.

line 226 appends ERROR when the executable crashes.

p = subprocess.Popen(cmd, cwd=cwd, stdout=subprocess.PIPE, stderr=subprocess.STDOUT, close_fds=should_close, shell=True) output = p.communicate()[0].decode('utf-8') if (p.returncode != 0): output = 'ERROR: ' + output

I can't change the code in the runCommand function because its called by the testHarness and shouldn't exit if it segfaults, it should return an ERROR.

lynnmunday requested review from loganharbour and milljm as code owners April 16, 2025 17:06

dschwen reviewed Apr 16, 2025

View reviewed changes

lynnmunday force-pushed the capabilities_tester_error branch from 7ad2b12 to 61de797 Compare April 18, 2025 20:10

added error when executable crashes with the --show-capabilities option

e3eaf0b

closes idaholab#30340

lynnmunday force-pushed the capabilities_tester_error branch from 61de797 to e3eaf0b Compare April 22, 2025 17:58

dschwen reviewed Apr 23, 2025

View reviewed changes

GiudGiud assigned dschwen May 2, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added error when executable crashes #30341

added error when executable crashes #30341

lynnmunday commented Apr 16, 2025

moosebuild commented Apr 16, 2025 •

edited

Loading

moosebuild commented Apr 16, 2025 •

edited

Loading

dschwen Apr 16, 2025

lynnmunday Apr 16, 2025 •

edited

Loading

dschwen Apr 18, 2025

lynnmunday Apr 18, 2025

lynnmunday commented Apr 18, 2025

moosebuild commented Apr 18, 2025

moosebuild commented Apr 21, 2025

moosebuild commented Apr 21, 2025

moosebuild commented Apr 21, 2025

lynnmunday commented Apr 22, 2025

lynnmunday commented Apr 22, 2025

dschwen Apr 23, 2025

lynnmunday Apr 23, 2025

added error when executable crashes #30341

Are you sure you want to change the base?

added error when executable crashes #30341

Conversation

lynnmunday commented Apr 16, 2025

moosebuild commented Apr 16, 2025 • edited Loading

moosebuild commented Apr 16, 2025 • edited Loading

Framework coverage

Modules coverage

Full coverage reports

dschwen Apr 16, 2025

Choose a reason for hiding this comment

lynnmunday Apr 16, 2025 • edited Loading

Choose a reason for hiding this comment

dschwen Apr 18, 2025

Choose a reason for hiding this comment

lynnmunday Apr 18, 2025

Choose a reason for hiding this comment

lynnmunday commented Apr 18, 2025

moosebuild commented Apr 18, 2025

moosebuild commented Apr 21, 2025

moosebuild commented Apr 21, 2025

moosebuild commented Apr 21, 2025

lynnmunday commented Apr 22, 2025

lynnmunday commented Apr 22, 2025

dschwen Apr 23, 2025

Choose a reason for hiding this comment

lynnmunday Apr 23, 2025

Choose a reason for hiding this comment

moosebuild commented Apr 16, 2025 •

edited

Loading

moosebuild commented Apr 16, 2025 •

edited

Loading

lynnmunday Apr 16, 2025 •

edited

Loading