Add skip_evals option to Terminator UserObject for problems. Closes #… #30344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job Documentation, step Docs: sync website on 0dad1eb wanted to post the following: View the site here This comment will be updated on new commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #30343
Reason
Handle initial numerical issues for Terminators
Design
Add a counter and a user-specified cutoff for disabling the first
nexecutions of the Terminator.Technically, I believe there's an off-by-one error here, but with the default behavior,
skip_evalslines up better with the timestep number, so I thought it might be better to have this behavior.Impact
Something new, existing API should be unaffected