-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/fees refund #121
Feat/fees refund #121
Conversation
d78fe43
to
371da1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juangirini looks good to me. Coming along nicely, only left a comment related to a nice to have comments on the implementation of fees calculation and associated functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Feat/fees refund
closes #104
closes #107
This pull request implements the fees refund feature and introduces several enhancements and fixes to the subscription management system. The key changes are as follows:
Summary
Description
New Features and Enhancements
Fees Management Improvements:
BalanceDirection
andDiffBalance
structs to represent and handle balance movements.FeesManager
trait to include methods for calculating fee differences (calculate_diff_fees
) and collecting fees with references (collect_fees
).Subscription Management Enhancements:
calculate_diff_deposit
).FeesCollected
andSubscriptionRemoved
.Fee Calculation Logic:
Testing Enhancements:
Code Refactoring: