Feat: mpsc channel #125
Feat: mpsc channel #125
Conversation
| let data_lock = state.lock().unwrap(); | ||
| let pulses = &data_lock.pulses; | ||
| assert!(pulses.len() == 0); | ||
| sleep(Duration::from_millis(7000)).await; |
There was a problem hiding this comment.
This is quite a lot of waiting, why is that? and why did you need to increase it?
There was a problem hiding this comment.
This test actually connects to drand's gossipsub. Waiting 7 seconds ensure we get enough pulses. It's probably not necessary to wait that long but it provides a strong guarantee that we would have consumed at least two messages from the topic.
There was a problem hiding this comment.
Is this something that we could do with a mock?
There was a problem hiding this comment.
It can be mocked, but I still think it's good to have an e2e test that consumes from the real drand.
There was a problem hiding this comment.
@driemworks looks good overall imo. Nice tests, my only comment would be to differentiate those tests with actual dependency to the drand network to be more like integration or e2e tests
|
@colemanirby Gotcha, I removed the changes to the tarpaulin config. |
This replaces the
SharedStatestruct with an mpsc channel, where it uses aTracingUnboundedSenderto write well-formatted pulses from the gossipsub topic. Pulses can be read with a correspondingTracingUnboundedReceiverupdate tarpaulin config to output html reports and update gitignore to ignore it