Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/set mongo db #17

Merged
merged 30 commits into from
Oct 9, 2024
Merged

Feat/set mongo db #17

merged 30 commits into from
Oct 9, 2024

Conversation

juangirini
Copy link
Contributor

@juangirini juangirini commented Oct 9, 2024 •
edited
Loading

closes #15
closes #2

requieres compannion ideal-lab5/murmur#20

colemanirby and others added 27 commits September 30, 2024 11:46
@colemanirby
DB connection complete
d0ca787
@colemanirby
Verified Creation and Deletion of records
3b23a3a
@colemanirby
included extra deletion functionality
c46e971
@colemanirby
merging main
a5eb9b0
@colemanirby
Added back DB functionality
81a604b
@colemanirby
updated methods for loading and storing in db
b5f6ad0
@colemanirby
adding object id to cookies for mmr retrieval during later sessions
36746a2
@colemanirby
Flipped flag to use mongodb by default, removed test endpoints, clean…
4b73c7f 
…ed up dependencies
@colemanirby
pushing cleanup
5a6c7ee
@colemanirby
removed file store methods. Added error handling to store.rs
d7e41af
@colemanirby
removed object_id from cookie retrieval
6a7c57b
@colemanirby
moved error handling up one level for writing to DB
70d1508
@colemanirby
code cleanup
1005022
@colemanirby
Full error handling implemented. Need different Error codes for none-…
1f46df0 
…severe issues such as having no records
@colemanirby
updated status code for no record in db to 400
f4d9567
@colemanirby
Added error handling to record insertion
525d84a
@colemanirby
updated formatting
775ab21
@colemanirby
using Store struct which is managed by Rocket
cfc27fa
@colemanirby
resolving merge conflict
9232daa
@juangirini
Update src/main.rs
a92addd
@juangirini
Update src/main.rs
635dcfe
@juangirini
Update src/store.rs
733c355
@juangirini
Update src/store.rs
683f338
@juangirini
chore: clean up code
cc4d987
@juangirini
chore: fix merge conflicts
d9aa4b2
@juangirini
fix: make MurmurStore writable to db and fix update case
047f884
@juangirini
chore: add .env.template
dc86f25
@juangirini juangirini mentioned this pull request Oct 9, 2024
Merged
@juangirini juangirini requested a review from driemworks October 9, 2024 12:23
@juangirini juangirini mentioned this pull request Oct 9, 2024
Closed
@juangirini juangirini self-assigned this Oct 9, 2024
driemworks
driemworks reviewed Oct 9, 2024
View reviewed changes
driemworks
driemworks approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@driemworks driemworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juangirini juangirini merged commit 8723195 into main Oct 9, 2024
1 check passed
@juangirini juangirini deleted the feat/set-mongo-db branch October 14, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driemworks driemworks driemworks approved these changes

@colemanirby colemanirby Awaiting requested review from colemanirby

@carloskiron carloskiron Awaiting requested review from carloskiron

Assignees

@juangirini juangirini

Labels
None yet
Projects
Murmur
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move hardcoded const to env var murmur-api: setup mongodb or similar
3 participants
@juangirini @driemworks @colemanirby