Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create a murmur lib for create and prepare_execute #9

Merged
merged 5 commits into from
Sep 27, 2024
Merged

feat: create a murmur lib for create and prepare_execute #9

merged 5 commits into from
Sep 27, 2024

Conversation

juangirini
Copy link
Contributor

@juangirini juangirini commented Sep 27, 2024 •
edited
Loading

This PR creates a new murmur-lib library crate that extracts the public functions create and prepara_execute from the cli so they can be reused (motivated by the murmur-api)

driemworks
driemworks approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@driemworks driemworks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@juangirini juangirini mentioned this pull request Sep 27, 2024
Closed
@juangirini juangirini merged commit 44e03dc into dev Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driemworks driemworks driemworks approved these changes

@colemanirby colemanirby Awaiting requested review from colemanirby

@carloskiron carloskiron Awaiting requested review from carloskiron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juangirini @driemworks