Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/stream cipher #10

Merged
merged 17 commits into from
Nov 20, 2024
Merged

Feat/stream cipher #10

merged 17 commits into from
Nov 20, 2024

Conversation

driemworks
Copy link
Contributor

  • closes Create timelock library #6
  • introduces greater modularity for the timelock library by introducing a StreamCipherProvider to allow any cipher to be specified (e.g. AES GCM by default, but could support AGE or others)
  • refines benchmarks
  • introduces wasm bindings for the timelock encryption rust library

Copy link
Contributor

@juangirini juangirini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Most of my comments are just nits or suggestions.
There are two issues to be addressed before merging:

  • tlock bench does not compile, it's just a matter of bringing the right imports
  • benches and wasm throw compile warnings

Also, there are a few unwraps that would be good to tackle in another PR.

Lastly, I got a bit lost with all the variants: tlock, tle and timelock. They are all used across the repo, would it make sense to unify the terminology?

Copy link
Contributor

@juangirini juangirini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@driemworks driemworks merged commit 6420b22 into main Nov 20, 2024
@driemworks driemworks deleted the feat/stream-cipher branch November 20, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create timelock library
2 participants