-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/stream cipher #10
Conversation
driemworks
commented
Nov 19, 2024
- closes Create timelock library #6
- introduces greater modularity for the timelock library by introducing a StreamCipherProvider to allow any cipher to be specified (e.g. AES GCM by default, but could support AGE or others)
- refines benchmarks
- introduces wasm bindings for the timelock encryption rust library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good. Most of my comments are just nits or suggestions.
There are two issues to be addressed before merging:
- tlock bench does not compile, it's just a matter of bringing the right imports
- benches and wasm throw compile warnings
Also, there are a few unwraps that would be good to tackle in another PR.
Lastly, I got a bit lost with all the variants: tlock, tle and timelock. They are all used across the repo, would it make sense to unify the terminology?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍