Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VC-related refactors and fixes #49

Merged
merged 10 commits into from
Jun 26, 2024
Merged

VC-related refactors and fixes #49

merged 10 commits into from
Jun 26, 2024

Conversation

eginhard
Copy link
Member

@eginhard eginhard commented Jun 25, 2024

  • Enable and fix some tests that were not running before
  • Replace non-existing function get_d_vector_by_name with get_mean_embedding
  • Address Pytorch deprecations
  • Remove some duplicate code
  • Improve type hints

@eginhard eginhard requested a review from KarlHajal June 26, 2024 10:41
@eginhard eginhard merged commit ff2cd5c into dev Jun 26, 2024
49 checks passed
@eginhard eginhard deleted the vc-refactors branch June 26, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants