Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clarifying text for media types #33

Open
tfpauly opened this issue Feb 3, 2025 · 2 comments · May be fixed by #34
Open

Add clarifying text for media types #33

tfpauly opened this issue Feb 3, 2025 · 2 comments · May be fixed by #34

Comments

@tfpauly
Copy link
Contributor

tfpauly commented Feb 3, 2025 •
edited
Loading

This document defines four new media types, but it seems to be missing some descriptive and normative text.

Section 6.2 mentions:
"The Content-Type is application/private-token-arbitrary-batch-request as registered with IANA."

This is a good step, but the equivalent text for the other three types is not there. They are mentioned in examples, and in IANA, but not in the descriptive text.

I think for each, we need to:

  • In the main section that is relevant, mention the media type and link to IANA
  • Add a normative explanation of how to use the media type ("The Content-Type for this request MUST be...")
  • Add normative text about how to verify the media type
thibmeu added a commit to thibmeu/ietf-draft-privacypass-batched-tokens that referenced this issue Feb 7, 2025
@thibmeu
Add clarification for media type
0ba923b 
All media types declared with IANA registered the same subtype. This
commit addresses it.

In addition, this commit makes the Content-Type for request and
responses normative with `MUST be`.

Closes ietf-wg-privacypass#33
thibmeu added a commit to thibmeu/ietf-draft-privacypass-batched-tokens that referenced this issue Feb 7, 2025
@thibmeu
Add clarification for media type
e58be1e 
All media types declared with IANA registered the same subtype. This
commit addresses it.

In addition, this commit makes the Content-Type for request and
responses normative with `MUST be`.

Closes ietf-wg-privacypass#33
@thibmeu thibmeu linked a pull request Feb 7, 2025 that will close this issue
Open
@thibmeu
Copy link
Contributor

thibmeu commented Feb 7, 2025

I have opened #34 to address this issue.

One question though is what do you mean by Add normative text about how to verity the media type? Would this be text that goes in the IANA section as to which structure should be parsed when seeing said content type?
In this case, is the wording on #34 good enough as it mentions "as defined in {{section}}"

thibmeu added a commit to thibmeu/ietf-draft-privacypass-batched-tokens that referenced this issue Feb 7, 2025
@thibmeu
Add clarification for media type
00a0404 
All media types declared with IANA registered the same subtype. This
commit addresses it.

In addition, this commit makes the Content-Type for request and
responses normative with `MUST be`.

Closes ietf-wg-privacypass#33
@tfpauly
Copy link
Contributor Author

tfpauly commented Feb 7, 2025

For Add normative text about how to verify the media type, I was thinking that we need to explain "if you receive a response without the expected type, you MUST ignore the response" or something like that. What do you do about the received type, essentially.

thibmeu added a commit to thibmeu/ietf-draft-privacypass-batched-tokens that referenced this issue Feb 8, 2025
@thibmeu
Add clarification for media type
6a87162 
All media types declared with IANA registered the same subtype. This
commit addresses it.

In addition, this commit makes the Content-Type for request and
responses normative with `MUST be`.

Closes ietf-wg-privacypass#33
thibmeu added a commit to thibmeu/ietf-draft-privacypass-batched-tokens that referenced this issue Feb 9, 2025
@thibmeu
Add clarification for media type
b2b46a9 
All media types declared with IANA registered the same subtype. This
commit addresses it.

In addition, this commit makes the Content-Type for request and
responses normative with `MUST be`.

Closes ietf-wg-privacypass#33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add clarification for media type thibmeu/ietf-draft-privacypass-batched-tokens
2 participants
@tfpauly @thibmeu