Add test vectors for batched privately verifiable tokens and arbitrary #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The draft has been updated, namely on the token type which hsas moved from 0xF91A to 0x0005. This PR has to be updated. In addition, CI has to be fixed. |
thibmeu
force-pushed
the
add-test-vectors
branch
from
09e6ace to
01c7e1e
Compare
Tests vectors are constructed from [a Go implementation](https://github.com/cloudflare/pat-go/). Closes ietf-wg-privacypass#20 and ietf-wg-privacypass#21.
Changed in ietf-wg-privacypass#27. Tests vectors have been regenerated in the Go implementation using cloudflare/pat-go#50
Was written as iana-token-typee 🤦
Updated the go implementation to use varint TypeScript implementation PR are underways.
thibmeu
force-pushed
the
add-test-vectors
branch
from
7805684 to
b7ad078
Compare
|
@raphaelrobert removed test vectors 6 and 7, and I have also updated the description of arbitrary batched tokens accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests vectors are constructed from a Go implementation.
This has be to updated if #27 is merged, as it updates the token type from 0xf91a to 0x0005.
Closes #20 and #21.
cc @raphaelrobert