Skip to content

Editorial pass on batched tokens #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2025

Conversation

tfpauly
Copy link
Contributor

@tfpauly tfpauly commented Feb 3, 2025

No description provided.

ghost

This comment was marked as spam.

Copy link
Contributor

@thibmeu thibmeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one comment on possible conflict with #34. I'd say we keep this update and I'll update my PR once this one is merged.

I don't have merge permissions, so approving but deferring to @chris-wood or @raphaelrobert for merging

@@ -409,19 +410,19 @@ struct {
If the FinalizeBatch function fails, the Client aborts the protocol. Token
verification works exactly as specified in {{RFC9578}}.

# Arbitrary Batched Token Issuance
# Arbitrary Batched Token Issuance {#batched-arbitrary}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: this is also introduced in #34

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it's only fair to re-align #34 in that case

Copy link
Collaborator

@raphaelrobert raphaelrobert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tfpauly!

@raphaelrobert raphaelrobert merged commit fa9a71a into ietf-wg-privacypass:main Feb 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants