OF-2716: Fix Licences #2370
Merged
OF-2716: Fix Licences #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Script moved to https://gist.github.com/Fishbowler/ed6a05c4e7b7ba539f814df3f54e5772 |
|
I'm going to rewrite history to remove the script. |
For files that have copyright assigned to some variant of Ignite, and where it should be Ignite Realtime Foundation, fix it. Mostly s/Community/Foundation
We want [YEAR] [OWNER], not the other way around
This file was missed in OF-65 / commit 324dd3b and was relicensed by Jive to Apache. This just fixes the header to reflect that decision.
…thers Just to aid scriptable checking. Also adds Ignite's contributions.
For JSP or Java files in the repo, detect and add missing license headers. Copyright headers are reconstructed from git history.
…nse header Via script, add Ignite to the copyright line for Java and JSP files, using git history to calculate the correct years.
Via script, use git history to amend years of edits of the file
Via script, amend any items missing the (C) after Copyright, amend any items missing 'All rights reserved' at the end of the copyright line, then run other fixes now that they're consistent.
The script's auto-fixes highlighted that some files had incorrect attributions.
Fix more files that the script worked out were wrong, but couldn't fix automatically
|
Done, ready for merge |
guusdk
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
I've skimmed over examples of the changes, with regards to years and legal entity references, which seems to be fine.
I've used (suboptimal) bash grepping to verify that all changes in this PR affect lines that are in comment, which turns out to be the case nearly everywhere (some JSP import statements got moved around too, which is fine):
git diff 68ecdf119e6f17e81f84bef84d5a2b2dcd2c0edf HEAD | grep "^[\+\-]" | grep -v "^---" | grep -v "^++" | grep -v -E '^[+-] \*' | grep -v "^[+-] -"
That's all that I can think of to sensibly review this PR. Thanks for all of the effort that has gone into this, @Fishbowler !
akrherz
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #2367 (because I accidentally deleted the branch)