OF-2960: Replace Oracle database driver's BOM project with individual dependencies #2675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishbowler
approved these changes
Feb 7, 2025
Fishbowler
reviewed
Feb 7, 2025
Comment on lines
+93
to
+98
| <dependency> <!-- OF-2960: Including dependencies of ojdbc11-production rather than ojdbc11-production itself. --> | ||
| <groupId>com.oracle.database.jdbc</groupId> | ||
| <artifactId>ojdbc11</artifactId> | ||
| <version>${ojdbc.version}</version> | ||
| </dependency> |
There was a problem hiding this comment.
This fails in the tests because my hacky CI Updater test rig isn't a child project of the parent POM. Should we make it be a child? No clue if there'd be side effects.
There was a problem hiding this comment.
Possibly a good idea, but for now, I just defined the version number in its properties, too.
… dependencies This works around an issue that creeps up when using the BOM project: it causes a POM file to be included in Openfire's distirbution. That file in turn causes the RPM build to fail. As the distribution cannot be easily changed, this commit prevents usage of the project that introduces the POM file.
guusdk
force-pushed
the
OF-2960_Oracle-JDBC-driver-nonPom
branch
from
04142ce to
eab1f4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works around an issue that creeps up when using the BOM project: it causes a POM file to be included in Openfire's distirbution. That file in turn causes the RPM build to fail.
As the distribution cannot be easily changed, this commit prevents usage of the project that introduces the POM file.
More context is provided in https://igniterealtime.atlassian.net/browse/OF-2960