OF-2883: Add fallback to older style base64 encoding for security.xml #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Openfire 4.9.0, the base64 encoder was changed. This causes a compatibility issue with security.xml files that were generated by older values, that use the 'MIME' type of decoding (with linebreaks) that's not used in later versions. While persisting data in 'security.xml', linebreaks are replaced by white space. With the changes in this commit, the decoder checks for white space, and uses the older-style type of decoding when found.
Fishbowler
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Openfire 4.9.0, the base64 encoder was changed. This causes a compatibility issue with security.xml files that were generated by older values, that use the 'MIME' type of decoding (with linebreaks) that's not used in later versions. While persisting data in 'security.xml', linebreaks are replaced by white space.
With the changes in this commit, the decoder checks for white space, and uses the older-style type of decoding when found.